Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: use pdqsort to improve sort performance #34404

Merged
merged 7 commits into from
Jul 6, 2022
Merged

*: use pdqsort to improve sort performance #34404

merged 7 commits into from
Jul 6, 2022

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented May 6, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #34250

Problem Summary:

What is changed and how it works?

  • use pdqsort to sort sort: use pdqsort golang/go#50154, In common patterns, pdqsort is often faster (i.e. 10x faster in sorted slices).
  • remove github.com/cznic/sortutil

BTW, it is not only improved performance by using the pdqsort, but also it can remove BCE by the using generics to improve performance.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented May 6, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • bb7133
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2022
@hawkingrei hawkingrei force-pushed the try_to_use_pdqsort branch from f8a0483 to 83ffaa7 Compare May 6, 2022 03:39
@sre-bot
Copy link
Contributor

sre-bot commented May 6, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/c7356a330d97873da686f36b08be5974d3954ea1

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 6, 2022
@hawkingrei
Copy link
Member Author

/run-all-tests

@hawkingrei
Copy link
Member Author

/run-all-test

@hawkingrei hawkingrei force-pushed the try_to_use_pdqsort branch from 6664b81 to 04a5eb7 Compare May 6, 2022 04:08
@purelind
Copy link
Contributor

purelind commented May 6, 2022

/run-build

@hawkingrei
Copy link
Member Author

/run-all-tests

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 6, 2022
@hawkingrei hawkingrei force-pushed the try_to_use_pdqsort branch from 0a59ac8 to c7d0943 Compare May 6, 2022 08:06
@hawkingrei hawkingrei force-pushed the try_to_use_pdqsort branch 2 times, most recently from 026cf7a to 00ab823 Compare May 6, 2022 10:02
@hawkingrei hawkingrei requested a review from a team as a code owner May 6, 2022 11:07
@hawkingrei hawkingrei force-pushed the try_to_use_pdqsort branch from 0718381 to 2cd0af5 Compare May 6, 2022 14:40
@hawkingrei hawkingrei changed the title *: use pdqsort *: use pdqsort to improve sort performance May 6, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

1 similar comment
@hawkingrei
Copy link
Member Author

/run-mysql-test

@hawkingrei hawkingrei mentioned this pull request May 6, 2022
Open
@hawkingrei hawkingrei force-pushed the try_to_use_pdqsort branch 3 times, most recently from e19aa5c to c748869 Compare May 7, 2022 05:11
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 6, 2022
@hawkingrei
Copy link
Member Author

Should we merge #35970 first?

I find the latest revive can find more problems in the repo. I will spend much time to fix them.

@xhebox
Copy link
Contributor

xhebox commented Jul 6, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d256d76aab21f2f2cf98aac0d373c627b2fbcf61

@ti-chi-bot ti-chi-bot added status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 6, 2022
hawkingrei added 3 commits July 6, 2022 12:01
@hawkingrei
*: enable revive
e821eb0 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
ignore gci
72e8796 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei
*: enable revive
a0b7a7d 
Signed-off-by: Weizhen Wang <[email protected]>
@hawkingrei hawkingrei force-pushed the try_to_use_pdqsort branch from d256d76 to a0b7a7d Compare July 6, 2022 04:02
@ti-chi-bot ti-chi-bot removed status/can-merge Indicates a PR has been approved by a committer. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 6, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a0b7a7d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022
@hawkingrei
*: enable revive
1ab85b8 
Signed-off-by: Weizhen Wang <[email protected]>
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1ab85b8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2022
@hawkingrei
Copy link
Member Author

/run-mysql-test

@ti-chi-bot ti-chi-bot merged commit 55aea27 into pingcap:master Jul 6, 2022
@hawkingrei hawkingrei deleted the try_to_use_pdqsort branch July 6, 2022 06:04
@sre-bot
Copy link
Contributor

sre-bot commented Jul 6, 2022

TiDB MergeCI notify

✅ Well Done! New fixed [1] after this pr merged.

CI Name Result Duration Compare with Parent commit
idc-jenkins-ci-tidb/tics-test 🔴 failed 1, success 0, total 1 13 min Existing failure
idc-jenkins-ci-tidb/common-test ✅ all 12 tests passed 12 min Fixed
idc-jenkins-ci/integration-cdc-test 🟢 all 35 tests passed 26 min Existing passed
idc-jenkins-ci-tidb/integration-common-test 🟢 all 11 tests passed 23 min Existing passed
idc-jenkins-ci-tidb/sqllogic-test-1 🟢 all 26 tests passed 5 min 55 sec Existing passed
idc-jenkins-ci-tidb/sqllogic-test-2 🟢 all 28 tests passed 5 min 46 sec Existing passed
idc-jenkins-ci-tidb/integration-ddl-test 🟢 all 6 tests passed 5 min 35 sec Existing passed
idc-jenkins-ci-tidb/mybatis-test 🟢 all 1 tests passed 2 min 59 sec Existing passed
idc-jenkins-ci-tidb/integration-compatibility-test 🟢 all 1 tests passed 2 min 50 sec Existing passed
idc-jenkins-ci-tidb/plugin-test 🟢 build success, plugin test success 4min Existing passed

morgo added a commit to morgo/tidb that referenced this pull request Jul 6, 2022
@morgo
Merge remote-tracking branch 'upstream/master' into improve-skip-init
10c7409 
* upstream/master: (77 commits)
  infoschema: add a simply store for DM's SchemaTracker (pingcap#35954)
  planner: refactor "access object" related logic and prepare for binary plan (pingcap#35890)
  telemetry: Initialize telemetry asynchronously (pingcap#35898)
  sessionctx/variable: convert TiDBLogFileMaxDays and TiDBConfig to ScopeInstance (pingcap#35733)
  session, sessionctx/variable: ensure sysvars are always in lower case (pingcap#35659)
  *: add telemetry support for multi-schema change (pingcap#35977)
  topsql: compress plan instead of dropping it (pingcap#35973)
  *: use pdqsort to improve sort performance (pingcap#34404)
  ddl: refine GetDDLInfo function (pingcap#35969)
  *: Make the code cleaner in session.ExecutePreparedStmt (pingcap#35943)
  ddl: remove `onDropIndexes` (pingcap#35960)
  ddl: refine history job code (pingcap#35967)
  sessionctx,kv,planner: add system variable for fine_grained_shuffle (pingcap#35256)
  *: change remote cache (pingcap#35968)
  *: enable gosec (pingcap#35873)
  plancodec: fix a miss case in conversion (pingcap#35957)
  ddl: support drop indexes for multi-schema change (pingcap#35883)
  pdutil: fix unstable test TestPauseSchedulersByKeyRange (pingcap#35949)
  br: optimize communication with tikv stores. pingcap#31722 (pingcap#35147)
  txn: rename snapshot related methods in txnManager. (pingcap#35912)
  ...
@hawkingrei hawkingrei mentioned this pull request Jul 8, 2022
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

@bb7133 bb7133 bb7133 approved these changes

@AilinKid AilinKid Awaiting requested review from AilinKid

@Defined2014 Defined2014 Awaiting requested review from Defined2014

@disksing disksing Awaiting requested review from disksing

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use pdqsort to improve sort performance
6 participants
@hawkingrei @ti-chi-bot @sre-bot @purelind @xhebox @bb7133