planner: fix insert with select the same table result no error #issue 31363

[fanrenhoo]

Signed-off-by: fanrenhoo [email protected]

What problem does this PR solve?

Issue Number: close #31363

Problem Summary: insert into with select query on a same table no error return, not compatible with MySQL

What is changed and how it works?

Added in the parser in InsertStmt with the logic, if has insert stmt has subquery select stmt, check to make sure select with different table or use as alias to a different name

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
  mysql> drop table if exists t1;
  mysql> CREATE TABLE t1 (x int);
  mysql> INSERT INTO t1 (x) VALUES ((SELECT x FROM t1));ERROR 1093 (HY000): You can't specify target table 't1' for update in FROM clause

mysql> INSERT INTO t1 (x) VALUES ((SELECT x FROM t1 as t));
Query OK, 1 row affected (0.00 sec)

• No code

Side effects
no

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation
no

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Make the insert into with select on a same table result error as MySQL does, and if use "as alias" to different name so will be OK. this fix the issue #31363

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• xhebox
• xuyifangreeneyes

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[fanrenhoo]

/cc @xhebox

[sre-bot]

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/3d7547d1ab7c2fa6c93efcb00ee5076e1b1ea78e

[xhebox]

/cc @winoros

[xhebox]

BTW, we don't cherry-pick minor issue. I am not sure about the fix, it looks like a fix in preprocessor will make more sense.

[xhebox]

/test all

[ti-chi-bot]

@fanrenhoo: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[xhebox]

/hold

unit-test failed.

[xhebox]

/test all

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox, xuyifangreeneyes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xhebox,xuyifangreeneyes]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xhebox]

/test all

[tiprow]

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xhebox]

/test all

[tiprow]

@xhebox: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ti-chi-bot]

@fanrenhoo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
idc-jenkins-ci-tidb/check_dev_2	33ca045	link	true	/test check-dev2
idc-jenkins-ci-tidb/unit-test	33ca045	link	true	/test unit-test
idc-jenkins-ci-tidb/build	7f2bc97	link	true	/test build

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.