Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: migrate test-infra to testify for executor/shuffle_test.go #30514

Merged
merged 6 commits into from
Dec 13, 2021
Merged

executor: migrate test-infra to testify for executor/shuffle_test.go #30514

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7440d95
migrate test-infra to testify for shuffle_test.go
tongtongyin Dec 8, 2021
d45df02
Merge branch 'master' into migrate-test-infra-to-testify
tongtongyin Dec 8, 2021
6fbf272
migrate test-infra to testify for shuffle_test.go
tongtongyin Dec 8, 2021
9064024
Merge branch 'migrate-test-infra-to-testify' of github.com:tongtongyi…
tongtongyin Dec 8, 2021
e83a077
Merge branch 'master' into migrate-test-infra-to-testify
hawkingrei Dec 13, 2021
468406c
Merge branch 'master' into migrate-test-infra-to-testify
ti-chi-bot Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions executor/shuffle_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,20 +15,19 @@
package executor

import (
. "github.com/pingcap/check"
"testing"

"github.com/pingcap/tidb/expression"
"github.com/pingcap/tidb/parser/mysql"
"github.com/pingcap/tidb/types"
"github.com/pingcap/tidb/util/chunk"
"github.com/pingcap/tidb/util/mock"
"github.com/stretchr/testify/require"
)

var _ = SerialSuites(&testPartitionSuite{})

type testPartitionSuite struct {
}
func TestPartitionRangeSplitter(t *testing.T) {
t.Parallel()

func (s *testPartitionSuite) TestPartitionRangeSplitter(c *C) {
ctx := mock.NewContext()
concurrency := 2

Expand Down Expand Up @@ -60,9 +59,9 @@ func (s *testPartitionSuite) TestPartitionRangeSplitter(c *C) {

splitter := buildPartitionRangeSplitter(ctx, concurrency, byItems)
obtained, err := splitter.split(ctx, input, obtained)
c.Assert(err, IsNil)
c.Assert(len(obtained), Equals, len(expected))
require.NoError(t, err)
require.Len(t, obtained, len(expected))
for i := 0; i < len(obtained); i++ {
c.Assert(obtained[i], Equals, expected[i])
require.Equal(t, expected[i], obtained[i])
}
}