Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: add optimizer trace framework for physicalOptimize #30335

Merged
merged 21 commits into from
Jan 5, 2022
Merged

planner: add optimizer trace framework for physicalOptimize #30335

merged 21 commits into from
Jan 5, 2022

Conversation

rebelice
Copy link
Contributor

@rebelice rebelice commented Dec 2, 2021

What problem does this PR solve?

Issue Number: close #30334

Problem Summary:

What is changed and how it works?

Add optimize trace framework for physicalOptimize. In this pr, we add optimize trace common framework into physical optimize processing.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 2, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Yisaer
  • hawkingrei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 2, 2021
Yisaer
Yisaer reviewed Dec 7, 2021
View reviewed changes
util/tracing/opt_trace.go Outdated Show resolved Hide resolved
util/tracing/opt_trace.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2021
Yisaer
Yisaer reviewed Dec 28, 2021
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

planner/core/physical_plan_trace_test.go Outdated Show resolved Hide resolved
util/tracing/opt_trace.go Outdated Show resolved Hide resolved
util/tracing/opt_trace.go Outdated Show resolved Hide resolved
planner/core/find_best_task.go Outdated Show resolved Hide resolved
Yisaer
Yisaer reviewed Dec 30, 2021
View reviewed changes
planner/core/optimizer.go Outdated Show resolved Hide resolved
util/tracing/opt_trace.go Outdated Show resolved Hide resolved
util/tracing/opt_trace.go Outdated Show resolved Hide resolved
planner/core/plan.go Outdated Show resolved Hide resolved
@rebelice rebelice requested a review from Yisaer December 31, 2021 09:47
@rebelice
Copy link
Contributor Author

@Yisaer updated all.

@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 31, 2021
Yisaer
Yisaer approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2022
@sre-bot
Copy link
Contributor

sre-bot commented Jan 4, 2022 •
edited
Loading

Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/35203727612b0961253655e4292ee6bf0ae1bbff

hawkingrei
hawkingrei reviewed Jan 5, 2022
View reviewed changes
planner/core/physical_plan_trace_test.go

package core

import (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use testify to write new test case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see this

@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 5, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 5, 2022
@rebelice
Copy link
Contributor Author

rebelice commented Jan 5, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 04b4ad7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 5, 2022
@ti-chi-bot
Copy link
Member

@rebelice: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9acb2c2 into pingcap:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yisaer Yisaer Yisaer approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@time-and-fate time-and-fate Awaiting requested review from time-and-fate

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add optimizer trace framework for physicalOptimize
5 participants
@rebelice @ti-chi-bot @sre-bot @hawkingrei @Yisaer