Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: regard NULL as point when accessing composite index #29992

Closed
wants to merge 1 commit into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Nov 22, 2021

What problem does this PR solve?

Issue Number: close #29650

Problem Summary: planner: regard NULL as point when accessing composite index

What is changed and how it works?

planner: regard NULL as point when accessing composite index

Check List

Tests

  • Unit test

Release note

planner: regard NULL as point when accessing composite index

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@qw4990 qw4990 requested a review from a team as a code owner November 22, 2021 07:07
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 22, 2021
@ti-chi-bot
Copy link
Member

@qw4990: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -1857,6 +1857,10 @@ var defaultSysVars = []*SysVar{
s.EnablePseudoForOutdatedStats = TiDBOptOn(val)
return nil
}},
{Scope: ScopeGlobal | ScopeSession, Name: TiDBRegardNULLAsPoint, Value: BoolToOnOff(DefTiDBRegardNULLAsPoint), Type: TypeBool, SetSession: func(s *SessionVars, val string) error {
s.StmtCtx.RegardNULLAsPoint = TiDBOptOn(val)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to ResetContextOfStmt(), which will be called in ExecuteStmt(), there will be a new StmtCtx every time when you execute a statement.

vars.StmtCtx = sc

Seems we should put the option in SessionVars.

@qw4990
Copy link
Contributor Author

qw4990 commented Nov 29, 2021

Close since it's duplicated with #30244

@qw4990 qw4990 closed this Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: NullEQ cannot be used for composite indexes
3 participants