Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor, types: refactor CompareDatum #29866

Merged
merged 12 commits into from
Nov 22, 2021
Merged

executor, types: refactor CompareDatum #29866

merged 12 commits into from
Nov 22, 2021

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Nov 17, 2021 •
edited
Loading

Relate to #29867
CompareDatum uses collation implicitly which tends to error.
So I add an argument collator explicitly. Compare is introduced in this PR, and it will replace CompareDatum step by step.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@wjhuang2016
done
f7cd79f 
Signed-off-by: wjhuang2016 <[email protected]>
@wjhuang2016
fix
c8e4165 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 17, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • xiongjiwei

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2021
kennytm
kennytm reviewed Nov 17, 2021
View reviewed changes
types/datum.go Outdated Show resolved Hide resolved
@wjhuang2016
rename
69eb360 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 19, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 22, 2021
@wjhuang2016
fix
43590d5 
Signed-off-by: wjhuang2016 <[email protected]>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 22, 2021
@wjhuang2016
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 43590d5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 22, 2021
@wjhuang2016
Copy link
Member Author

/run-check_dev

@wjhuang2016
Copy link
Member Author

/run-check_dev_2

1 similar comment
@wjhuang2016
Copy link
Member Author

/run-check_dev_2

@ti-chi-bot ti-chi-bot merged commit 2bf67ff into pingcap:master Nov 22, 2021
@wjhuang2016 wjhuang2016 deleted the introduce_comparedatum_new branch November 17, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiongjiwei xiongjiwei xiongjiwei approved these changes

@kennytm kennytm kennytm approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wjhuang2016 @ti-chi-bot @kennytm @xiongjiwei