Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: fix tidb can't alter table from other-type with null value to timestamp with NOT NULL attribute #29664

Merged
merged 33 commits into from
Dec 3, 2021
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
b8bc2d8
fix tidb can't alter table from other-type with null value to timesta…
AilinKid Nov 10, 2021
e352e1a
encapsulate some common code into a function
AilinKid Nov 11, 2021
7cb1ffc
fix test case under explicit_defaults_for_timestamp=on
AilinKid Nov 11, 2021
359c68b
.
AilinKid Nov 11, 2021
d611c2f
go fmt
AilinKid Nov 12, 2021
b6dc47d
make fm t
AilinKid Nov 17, 2021
ba6ce57
make check-static happy
AilinKid Nov 17, 2021
bee4c12
address comment
AilinKid Nov 24, 2021
a33619c
fmt
AilinKid Nov 24, 2021
44a3e9b
Merge branch 'master' into fix-issue-29328
AilinKid Nov 24, 2021
c1ef387
Merge branch 'master' into fix-issue-29328
AilinKid Nov 25, 2021
c96375c
.
AilinKid Nov 25, 2021
d685092
just skip the reorg timezone setting
AilinKid Nov 25, 2021
20c575f
Merge branch 'master' into fix-issue-29328
AilinKid Nov 25, 2021
1aaa3ce
fmt
AilinKid Nov 25, 2021
e452c78
Update ddl/column_type_change_test.go
AilinKid Nov 30, 2021
8cbd491
Update ddl/column_type_change_test.go
AilinKid Nov 30, 2021
864347a
Merge branch 'master' into fix-issue-29328
AilinKid Nov 30, 2021
c4218a2
Merge branch 'master' into fix-issue-29328
AilinKid Nov 30, 2021
e1d0ce3
Merge branch 'master' into fix-issue-29328
AilinKid Dec 1, 2021
94e4b61
Merge branch 'master' into fix-issue-29328
AilinKid Dec 1, 2021
cca90e5
Merge branch 'master' into fix-issue-29328
AilinKid Dec 2, 2021
4a49f77
Merge branch 'master' into fix-issue-29328
AilinKid Dec 2, 2021
66a7026
Merge branch 'master' into fix-issue-29328
AilinKid Dec 2, 2021
c1f73b2
Merge branch 'master' into fix-issue-29328
ti-chi-bot Dec 2, 2021
d1aabf7
Merge branch 'master' into fix-issue-29328
ti-chi-bot Dec 2, 2021
984a9cb
Merge branch 'master' into fix-issue-29328
ti-chi-bot Dec 2, 2021
64890e2
Merge branch 'master' into fix-issue-29328
ti-chi-bot Dec 3, 2021
de0574c
Merge branch 'master' into fix-issue-29328
ti-chi-bot Dec 3, 2021
3cb1493
Merge branch 'master' into fix-issue-29328
ti-chi-bot Dec 3, 2021
ffb94fc
Merge branch 'master' into fix-issue-29328
ti-chi-bot Dec 3, 2021
4a549e2
fix test
AilinKid Dec 3, 2021
4c8b7e3
Merge branch 'master' into fix-issue-29328
AilinKid Dec 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make check-static happy
Signed-off-by: ailinkid <[email protected]>
AilinKid committed Nov 22, 2021
commit ba6ce57b6c4a046a3326820e4d1706a379b21ccc
2 changes: 1 addition & 1 deletion expression/helper.go
Original file line number Diff line number Diff line change
@@ -85,7 +85,7 @@ func getTimeCurrentTimeStamp(ctx sessionctx.Context, tp byte, fsp int8) (t types

// GetTimeValue gets the time value with type tp.
func GetTimeValue(ctx sessionctx.Context, v interface{}, tp byte, fsp int8) (d types.Datum, err error) {
value := types.NewTime(types.ZeroCoreTime, tp, fsp)
var value types.Time

sc := ctx.GetSessionVars().StmtCtx
switch x := v.(type) {