Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copr: add paging API for streaming-like process #29612

Merged
merged 43 commits into from
Nov 30, 2021
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
c44f96a
add paging result
you06 Nov 2, 2021
bfc82e9
add paging result
you06 Nov 2, 2021
f5e937f
use page selection
you06 Nov 2, 2021
4528511
add paging copr
you06 Nov 3, 2021
565a6cf
fix bug
you06 Nov 3, 2021
f341ab9
there is a bug hard to fix
you06 Nov 3, 2021
a588b1b
update
you06 Nov 4, 2021
ff94658
remove incorrect error
you06 Nov 4, 2021
481a6c0
slow growth of paging size
you06 Nov 5, 2021
f000f14
make table read paging
you06 Nov 5, 2021
cb72861
clean up code
you06 Nov 9, 2021
a8ea777
remove unused code
you06 Nov 9, 2021
ff90d1a
close indexlookup executor in background
you06 Nov 10, 2021
321c7db
clean up
you06 Nov 18, 2021
7ed115f
clean up
you06 Nov 18, 2021
1c4a113
remove executor usage of paging
you06 Nov 23, 2021
ed1f80b
update go.mod
you06 Nov 23, 2021
3a389ef
add comment
you06 Nov 25, 2021
bf157df
add tests & comments
you06 Nov 25, 2021
5d46cba
add test & return error when paging and streaming are both on
you06 Nov 25, 2021
d088975
enlarge chan size for paging or streaming request
you06 Nov 25, 2021
b165410
Update store/copr/coprocessor.go
you06 Nov 26, 2021
0e57254
Update store/copr/coprocessor.go
you06 Nov 26, 2021
fe51c05
manually edit the ranges
you06 Nov 26, 2021
cf63a4f
enlarge channel size for ordered copr paging req
you06 Nov 26, 2021
4913c84
fix typo
you06 Nov 26, 2021
7c99ec8
Update store/copr/coprocessor.go
you06 Nov 26, 2021
4f54ae1
hide paging sysvar
you06 Nov 26, 2021
c08fceb
address comments
you06 Nov 29, 2021
ce7791a
fix lightning
you06 Nov 29, 2021
7127bbc
fix test of lightning
you06 Nov 29, 2021
0b0a4e3
merge master
you06 Nov 29, 2021
e2a3965
extract handleCopPagingResult & clean up
you06 Nov 29, 2021
659a65b
check exit cond
you06 Nov 29, 2021
57e0236
remove redundant build tasks
you06 Nov 29, 2021
241a4c4
clean up
you06 Nov 29, 2021
2a7e73b
add test for TestCalculateRetry
you06 Nov 29, 2021
657cb04
address comment
you06 Nov 29, 2021
8e322f0
remove build task for retry
you06 Nov 29, 2021
f5da091
handle nil split range
you06 Nov 30, 2021
2e74e45
Merge branch 'master' into add-paging-copr
ti-chi-bot Nov 30, 2021
857d64e
Merge branch 'master' into add-paging-copr
ti-chi-bot Nov 30, 2021
f199afb
Merge branch 'master' into add-paging-copr
ti-chi-bot Nov 30, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update store/copr/coprocessor.go
Co-authored-by: Lei Zhao <[email protected]>
you06 and youjiali1995 committed Nov 29, 2021

Verified

This commit was signed with the committer’s verified signature.
jwbonner Jonah Bonner
commit 0e572543ff3e119324d4ec8d9ca0b478f805ef03
2 changes: 1 addition & 1 deletion store/copr/coprocessor.go
Original file line number Diff line number Diff line change
@@ -720,7 +720,7 @@ func (worker *copIteratorWorker) handleTaskOnce(bo *Backoffer, task *copTask, ch
PagingSize: task.pagingSize,
}

var cacheKey []byte = nil
var cacheKey []byte
var cacheValue *coprCacheValue

// If there are many ranges, it is very likely to be a TableLookupRequest. They are not worth to cache since