-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix staled table cache usage inside a transaction #29443
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-check_dev_2 |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 24ad0dd
|
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Problem Summary:
A subtask of #25293
In session1:
then in session2:
in session1:
What is changed and how it works?
Start
field to table cache, txnTS
within[Start, Lease)
can use the cache databegin; sleep(1h)...
, then do some write operation, and reload the cache...In this case, comparing the
txn.StartTS()
with the[Start, Lease)
of the cache will fail, becausetxn.StartTS() < Start
, the cache is not used.Check List
Tests
Side effects
Documentation
Release note