Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: optimizing retry-able function #28434

Merged
merged 21 commits into from
Oct 14, 2021
Merged

Conversation

fengou1
Copy link
Contributor

@fengou1 fengou1 commented Sep 27, 2021

What problem does this PR solve?

Problem Summary:
Context Cancel is not retry-able. if gcs is temp unavailable, the backup will failure.

What is changed and how it works?

What's Changed:
if context cancel, do not retry
How it Works:

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please add a release note, or a 'None' if it is not needed.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 27, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • YuJuncen
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Sep 27, 2021

/cc @Lanearth @kennytm @YuJuncen

@ti-chi-bot ti-chi-bot requested a review from kennytm September 27, 2021 11:38
@ti-chi-bot
Copy link
Member

@fengou1: GitHub didn't allow me to request PR reviews from the following users: Lanearth.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @Lanearth @kennytm @YuJuncen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot requested a review from YuJuncen September 27, 2021 11:38
@fengou1 fengou1 changed the title fix issue 27015 br: Context Cancel is not retry-able Sep 27, 2021
@sre-bot
Copy link
Contributor

sre-bot commented Sep 27, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

1 similar comment
@sre-bot
Copy link
Contributor

sre-bot commented Sep 27, 2021

Please follow PR Title Format:

  • pkg [, pkg2, pkg3]: what is changed

Or if the count of mainly changed packages are more than 3, use

  • *: what is changed

After you have format title, you can leave a comment /run-check_title to recheck it

@kennytm
Copy link
Contributor

kennytm commented Sep 27, 2021

/run-check_title

br/pkg/conn/conn_test.go Outdated Show resolved Hide resolved
br/pkg/conn/conn_test.go Outdated Show resolved Hide resolved
br/pkg/utils/retry.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@kennytm kennytm added the component/br This issue is related to BR of TiDB. label Sep 27, 2021
@fengou1 fengou1 changed the title br: Context Cancel is not retry-able br: optimizing retry-able error Sep 28, 2021
@fengou1 fengou1 changed the title br: optimizing retry-able error br: optimizing retry-able function Sep 28, 2021
br/pkg/utils/retry.go Outdated Show resolved Hide resolved
@fengou1
Copy link
Contributor Author

fengou1 commented Oct 7, 2021

/cc @Leavrth

@ti-chi-bot ti-chi-bot requested a review from Leavrth October 7, 2021 05:21
@ti-chi-bot ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2021
@ti-chi-bot ti-chi-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 7, 2021
@fengou1
Copy link
Contributor Author

fengou1 commented Oct 7, 2021

/run-check_dev_2

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 11, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2021

CLA assistant check
All committers have signed the CLA.

@fengou1
Copy link
Contributor Author

fengou1 commented Oct 12, 2021

/run-check_dev_2

@fengou1
Copy link
Contributor Author

fengou1 commented Oct 12, 2021

/run-build

@fengou1
Copy link
Contributor Author

fengou1 commented Oct 12, 2021

/LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 12, 2021
@YuJuncen
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b7ced92

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2021
@ti-chi-bot ti-chi-bot merged commit f739a53 into pingcap:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/br This issue is related to BR of TiDB. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants