Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Add SHOW PLACEMENT support for tables #28266

Merged
merged 12 commits into from
Sep 26, 2021
Merged

*: Add SHOW PLACEMENT support for tables #28266

merged 12 commits into from
Sep 26, 2021

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

see #27976

What is changed and how it works?

*: Add SHOW PLACEMENT support for tables

Check List

Tests

  • Unit test

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • djshow832
  • xhebox

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2021
@lcwangchao lcwangchao mentioned this pull request Sep 22, 2021
Closed
@lcwangchao lcwangchao added the sig/sql-infra SIG: SQL Infra label Sep 22, 2021
djshow832
djshow832 reviewed Sep 23, 2021
View reviewed changes
executor/show_placement.go Show resolved Hide resolved
executor/show_placement.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2021
@lcwangchao
Copy link
Collaborator Author

/run-check_dev_2

xhebox
xhebox reviewed Sep 26, 2021
View reviewed changes
Copy link
Contributor

@xhebox xhebox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

executor/show_placement.go Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6adfaa4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2021
@djshow832
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: c021dd9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2021
@ti-chi-bot ti-chi-bot merged commit 61ddc74 into pingcap:master Sep 26, 2021
AilinKid
AilinKid reviewed Sep 26, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: after partition policy is done, the show statement here should include it

@lcwangchao lcwangchao mentioned this pull request Sep 26, 2021
Closed
@lcwangchao lcwangchao deleted the show_placement_tables branch October 18, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@djshow832 djshow832 djshow832 approved these changes

@xhebox xhebox xhebox approved these changes

@morgo morgo Awaiting requested review from morgo

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcwangchao @ti-chi-bot @djshow832 @xhebox @AilinKid