store/tikv: drop the unreachable store's regions from cache. #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngaut
reviewed
Mar 7, 2017
store/tikv/region_cache_test.go
Outdated
| @@ -254,6 +254,28 @@ func (s *testRegionCacheSuite) TestRequestFail(c *C) { | |||
| c.Assert(region.unreachableStores, HasLen, 0) | |||
| } | |||
|
|
|||
| func (s *testRegionCacheSuite) TestRequestFail2(c *C) { | |||
| // ['' - 'm' - 'z'] | |||
ngaut
reviewed
Mar 7, 2017
store/tikv/region_cache_test.go
Outdated
| c.Assert(err, IsNil) | ||
| c.Assert(loc2.Region.id, Equals, region2) | ||
|
|
||
| // Request fails on region1. |
AndreMouche
reviewed
Mar 7, 2017
store/tikv/region_cache_test.go
Outdated
| s.cache.OnRequestFail(ctx) | ||
| // Both region2 and store should be dropped from cache. | ||
| c.Assert(s.cache.storeMu.stores, HasLen, 0) | ||
| c.Assert(s.cache.getRegionFromCache([]byte("x")), IsNil) |
There was a problem hiding this comment.
It's hard for me to understand this test case==
There was a problem hiding this comment.
It first splits the cluster to 2 regions (region1, region2) while their leaders are on the same store (store1). After request fails on region1, we check if region2 and store1 are removed from cache.
|
LGTM |
|
PTAL @ngaut |
coocood
reviewed
Mar 8, 2017
| // Both region2 and store should be dropped from cache. | ||
| c.Assert(s.cache.storeMu.stores, HasLen, 0) | ||
| c.Assert(s.cache.getRegionFromCache([]byte("x")), IsNil) | ||
| s.checkCache(c, 1) |
There was a problem hiding this comment.
If only one store is used, why there is still one region in the cache?
There was a problem hiding this comment.
region1 is not removed, we have to try its other peers before reload it from pd, because pd may not be updated in time.
|
LGTM |
coocood
approved these changes
Mar 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a store is down and it contains a lot of regions (maybe up to 10k+), tidb will suffer from "connection refused" error for a long time.
cc @AndreMouche @shenli @hhkbp2