expression: do not rewrite like to = if new collation is enabled
#21893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # expression/integration_test.go
xiongjiwei
requested review from
a team and
lzmhhh123
and removed request for
a team
|
/run-all-tests |
|
there are some reasons to rewrite |
xiongjiwei
changed the title
like to = if pattern has no wildcardlike to = if pattern has no wildcard and new collation is enabled
xiongjiwei
changed the title
like to = if pattern has no wildcard and new collation is enabledlike to = if new collation is enabled
|
@winoros @wjhuang2016 PTAL |
ti-srebot
approved these changes
Dec 22, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@xiongjiwei merge failed. |
|
/merge |
|
/run-all-tests |
|
/label needs-cherry-pick-4.0 |
|
/run-cherry-pick |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jan 26, 2021
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-4.0 in PR #22531 |
ti-srebot
added a commit
that referenced
this pull request
Jan 27, 2021
…21893) (#22531) Signed-off-by: ti-srebot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #21892
likefunction and=are different if usingutf8mb4_unicode_cicollation even if the pattern does not has wildcard. so we cannot rewriteliketo=if new collation is enabled.see also operator_like
Check List
Tests
Release note
likefunction returns the wrong result when using collation