-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression, planner: fix decimal results for aggregate functions (#20017) #20984
expression, planner: fix decimal results for aggregate functions (#20017) #20984
Conversation
Signed-off-by: ti-srebot <[email protected]>
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/run-common-test tidb-test=pr/1100 |
/run-common-test |
/run-common-test tidb-test=pr/1104 |
Need to merge https://github.com/pingcap/tidb-test/pull/1104 first. |
/merge |
Sorry @lzmhhh123, you don't have permission to trigger auto merge event on this branch. |
/merge |
Sorry @qw4990, you don't have permission to trigger auto merge event on this branch. |
/run-all-tests |
/run-common-test tidb-test=pr/1104 |
1 similar comment
/run-common-test tidb-test=pr/1104 |
/run-integration-common-test tidb-test=pr/1104 |
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/run-common-test |
/run-integration-common-test |
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
@ti-srebot merge failed. |
/run-unit-test |
cherry-pick #20017 to release-4.0
What problem does this PR solve?
Issue Number: close #19426, fix PR #19592
Problem Summary:
Execute
Obtained
Expect
What is changed and how it works?
cast as decimal
for arguments ofgroup_concat
to preserve fraction part digits of the results.AppendFinalResult2Chunk
to the argument's precision.Related changes
Check List
Tests
Side effects
Release note