-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner/core: check the window func arg first before checking window specs (#11613) #11705
planner/core: check the window func arg first before checking window specs (#11613) #11705
Conversation
/run-all-tests |
Could you fix the CI? @gaoxingliang |
Hi, do you mean I need to fork from I run the code and found it passed. is the code in CI not latest version? in previous commits, it will cause this problem.
after I merged from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
cherry-pick #11613 to release-3.0
What problem does this PR solve?
Fix #11008.
What is changed and how it works?
it seems not a good idea but we need to be compatible with mysql.
so here, when extract windows funcs, it the continue to check the window arg. when checking window func arg, it need to be able to do the expression check.
Check List
Tests
Code changes
Side effects