Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: add metrics for bind info (#10921) #11467

Merged
merged 7 commits into from
Jul 29, 2019
Merged

metrics: add metrics for bind info (#10921) #11467

merged 7 commits into from
Jul 29, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 26, 2019

cherry-pick #10921 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 26, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Jul 26, 2019
Merged
@sre-bot sre-bot added component/metrics type/3.0 cherry-pick type/enhancement The issue or PR belongs to an enhancement. labels Jul 26, 2019
zz-jason
zz-jason reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested review from SunRunAway and eurekaka July 26, 2019 12:21
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2019
SunRunAway
SunRunAway approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 29, 2019

@sre-bot merge failed.

@SunRunAway
Copy link
Contributor

/run-unit-test

@zz-jason zz-jason merged commit 58aae12 into pingcap:release-3.0 Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@SunRunAway SunRunAway SunRunAway approved these changes

@eurekaka eurekaka Awaiting requested review from eurekaka

Assignees
No one assigned
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sre-bot @SunRunAway @zz-jason @alivxxx