*: add split table syntax to split table region #10553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazycs520
added
type/new-feature
require-LGT3
winkyao
reviewed
Jun 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #10553 +/- ##
================================================
- Coverage 79.6029% 79.5794% -0.0236%
================================================
Files 415 415
Lines 88101 88254 +153
================================================
+ Hits 70131 70232 +101
- Misses 12784 12828 +44
- Partials 5186 5194 +8 |
crazycs520
changed the title
|
/run-all-tests |
bb7133
reviewed
Jun 6, 2019
Co-Authored-By: bb7133 <[email protected]>
Co-Authored-By: bb7133 <[email protected]>
Co-Authored-By: bb7133 <[email protected]>
|
However, we should take care of the English syntax in self-made error messages. Different from code variables/comments, error messages are sent and shown to end-users. I advise making another PR to fix typos/misspellings in this PR and #10409, for example: https://github.com/pingcap/tidb/pull/10553/files#diff-ce300a40f7a5a1103912bc56991b9cb8R1794 |
|
/run-all-tests |
winkyao
reviewed
Jun 6, 2019
winkyao
reviewed
Jun 6, 2019
|
/run-all-tests |
zimulala
reviewed
Jun 10, 2019
executor/split.go
Outdated
| continue | ||
| } | ||
| regionIDs = append(regionIDs, regionID) | ||
|
|
There was a problem hiding this comment.
Remove this useless line.
zimulala
approved these changes
Jun 10, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jun 11, 2019
winkyao
pushed a commit
that referenced
this pull request
Jun 11, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Jun 20, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Please merge :#10409 first.
Add new syntax for
split table region.SPLIT TABLE [table_name] BETWEEN (min_value...) AND (max_value...) REGIONS [region_num] SPLIT TABLE [table_name] BY [value_lists]Attention
minandmaxvalue count should be 1.1000in a single query.Eg1
Upper sql will split
5regions of the tabletin range0~1000. Every region range like below:Region1: -inf ~ 200
Region2: 200 ~ 400
Region3: 400 ~ 600
Region4: 600 ~ 800
Region5: 800 ~ +inf
Eg2
Upper sql will split
4regions of the tablet, Every region range like below:Region1: -inf ~ 100
Region2: 100 ~ 200
Region3: 200 ~ 300
Region4: 300 ~ +inf
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes