table:modify 'desc' and 'show columns' statement is compatible with MySQL #10358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10358 +/- ##
===============================================
+ Coverage 77.383% 77.3841% +0.0011%
===============================================
Files 412 412
Lines 85573 85586 +13
===============================================
+ Hits 66219 66230 +11
- Misses 14334 14335 +1
- Partials 5020 5021 +1 |
|
/run-all-tests |
|
@mantuliu Please cherry-pick to release branch, many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
the issue 10337
What is changed and how it works?
when we use statements such as desc, show columns, etc., the value of the returned column 'Extra' is determined by the method in column.go: NewColDesc.
after the codes commit,when the type of the column is timestamp and is set to update according to the current timestamp, the return value of the statement such as desc for extra: DEFAULT_GENERATED on update CURRENT_TIMESTAMP.
Check List
Tests
Code changes
Side effects
Related changes