Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: addition between datetime and interval is not compatible with Mysql #10329

Merged
merged 21 commits into from
May 10, 2019
Merged

expression: addition between datetime and interval is not compatible with Mysql #10329

merged 21 commits into from
May 10, 2019

Conversation

erjiaqing
Copy link
Contributor

@erjiaqing erjiaqing commented Apr 30, 2019 •
edited
Loading

What problem does this PR solve?

Fix #9727

What is changed and how it works?

  • Changes in types/time.go is to extract day from duration to avoid overflow.

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Apr 30, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5617809). Click here to learn what that means.
The diff coverage is 84.2105%.

@@             Coverage Diff             @@
##             master     #10329   +/-   ##
===========================================
  Coverage          ?   77.4068%           
===========================================
  Files             ?        412           
  Lines             ?      85902           
  Branches          ?          0           
===========================================
  Hits              ?      66494           
  Misses            ?      14347           
  Partials          ?       5061

@qw4990 qw4990 self-requested a review May 6, 2019 02:53
@qw4990 qw4990 mentioned this pull request May 6, 2019
Closed
30 tasks
qw4990
qw4990 reviewed May 6, 2019
View reviewed changes
types/time.go Outdated Show resolved Hide resolved
@qw4990 qw4990 requested review from alivxxx and winoros May 6, 2019 08:19
alivxxx
alivxxx reviewed May 6, 2019
View reviewed changes
expression/builtin_time.go Outdated Show resolved Hide resolved
types/time.go Outdated Show resolved Hide resolved
winoros
winoros reviewed May 6, 2019
View reviewed changes
types/time.go Show resolved Hide resolved
qw4990
qw4990 reviewed May 7, 2019
View reviewed changes
types/time.go Outdated Show resolved Hide resolved
@qw4990 qw4990 mentioned this pull request May 7, 2019
Merged
qw4990
qw4990 reviewed May 8, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 requested review from alivxxx and winoros May 9, 2019 02:33
alivxxx
alivxxx reviewed May 9, 2019
View reviewed changes
types/time.go Show resolved Hide resolved
@erjiaqing erjiaqing requested a review from alivxxx May 9, 2019 12:39
alivxxx
alivxxx previously approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label May 10, 2019
@alivxxx
Copy link
Contributor

alivxxx commented May 10, 2019

/run-all-tests

@erjiaqing
Copy link
Contributor Author

/run-all-tests

zz-jason
zz-jason approved these changes May 10, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit d241d74 into pingcap:master May 10, 2019
erjiaqing added a commit to erjiaqing/tidb that referenced this pull request May 10, 2019
@erjiaqing
expression: addition between datetime and interval is not compati…
5408b2c 
…ble with Mysql (pingcap#10329)
@erjiaqing erjiaqing mentioned this pull request May 10, 2019
Merged
zz-jason pushed a commit that referenced this pull request May 10, 2019
@erjiaqing @zz-jason
expression: addition between datetime and interval is not compati…
6cb7bd1 
…ble with Mysql (#10329) (#10416)
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 left review comments

@zz-jason zz-jason zz-jason approved these changes

@alivxxx alivxxx alivxxx left review comments

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

addition between datetime and interval is not compatible with Mysql
6 participants
@erjiaqing @alivxxx @zz-jason @qw4990 @winoros @sre-bot