Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: adapt utf8mb4_0900_ai_ci collation #10183

Merged
merged 2 commits into from
Apr 18, 2019
Merged

*: adapt utf8mb4_0900_ai_ci collation #10183

merged 2 commits into from
Apr 18, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Apr 18, 2019 •
edited
Loading

What problem does this PR solve?

MySQL client 8.0 use utf8mb4_0900_ai_ci as default collation and login tidb with MySQL 8.0 client will meet error like #9426 and #6942

closes #9426
closes #6942

What is changed and how it works?

adapt utf8mb4_0900_ai_ci & doesn't throw a error

Check List

Tests

  • Unit test
  • Integration test

Code changes

Side effects

  • N/A

Related changes

  • Need to update the documentation
  • Need to be included in the release note

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Apr 18, 2019

/run-all-tests

1 similar comment
@lysu
Copy link
Contributor Author

lysu commented Apr 18, 2019

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Apr 18, 2019

@bb7133 @winkyao PTAL

@bb7133
Copy link
Member

bb7133 commented Apr 18, 2019

LGTM

@lysu lysu added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2019
@lysu lysu requested review from crazycs520 and tiancaiamao April 18, 2019 07:15
winkyao
winkyao previously approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu
Copy link
Contributor Author

lysu commented Apr 18, 2019

/run-all-tests

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 18, 2019
@ngaut ngaut merged commit a19f4d6 into pingcap:master Apr 18, 2019
@shenli
Copy link
Member

shenli commented Apr 18, 2019

Should we cherry-pick this to the release-2.1?

@lysu lysu mentioned this pull request Apr 19, 2019
Merged
jackysp pushed a commit that referenced this pull request Apr 22, 2019
@lysu @jackysp
*: adapt utf8mb4_0900_ai_ci collation (#10183) (#10201)
693c0a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut ngaut approved these changes

@winkyao winkyao winkyao left review comments

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for utf8mb4_0900_ai_ci in syntax. mysql client 8.0 failed to connect to tidb-server
5 participants
@lysu @bb7133 @shenli @ngaut @winkyao