Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit tests for package "aggfuncs" #7042

Closed
zz-jason opened this issue Jul 12, 2018 · 0 comments
Closed

add unit tests for package "aggfuncs" #7042

zz-jason opened this issue Jul 12, 2018 · 0 comments
Assignees
@XuHuaiyu
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Milestone
2.1

Comments

@zz-jason
Copy link
Member

currently we use the integration tests to test the new aggregate execution framework, but we still need to add unit tests to test the APIs to further avoid potential bugs.
@zz-jason zz-jason added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement. sig/execution SIG execution labels Jul 12, 2018
@zz-jason zz-jason added this to the 2.1 milestone Jul 12, 2018
This was referenced Oct 19, 2018
Merged
Merged
@ngaut ngaut closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XuHuaiyu XuHuaiyu

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@ngaut @zz-jason @XuHuaiyu