Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve observability of fast reorg ADD INDEX progress #56986

Open
lance6716 opened this issue Oct 30, 2024 · 4 comments
Open

Improve observability of fast reorg ADD INDEX progress #56986

lance6716 opened this issue Oct 30, 2024 · 4 comments
Assignees
Labels
component/ddl This issue is related to DDL of TiDB. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@lance6716
Copy link
Contributor

Enhancement

currently we only let progress forward when KV is written to TiKV. When fast reorg is enabled, data will be batched on disk for a long time. No progress will be made during that stage and some users may suspect DDL is stuck.

So I propose we draw another line in metrics, which means "how many record KV we have read to assume the index KV".

@lance6716 lance6716 added type/enhancement The issue or PR belongs to an enhancement. component/ddl This issue is related to DDL of TiDB. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 30, 2024
@D3Hunter
Copy link
Contributor

local backend already have BytesCounter, but not enabled for add-index

as a workaround, user can check Import & Backup panels of TiKV to see imported KVs and bytes

@lance6716
Copy link
Contributor Author

local backend already have BytesCounter, but not enabled for add-index

as a workaround, user can check Import & Backup panels of TiKV to see imported KVs and bytes

I mean show the progress of data that has not been sent to TiKV. Currently no workaround.

@D3Hunter
Copy link
Contributor

local backend already have BytesCounter, but not enabled for add-index
as a workaround, user can check Import & Backup panels of TiKV to see imported KVs and bytes

I mean show the progress of data that has not been sent to TiKV. Currently no workaround.

close estimation: disk-quota - already imported

@fishiu
Copy link
Contributor

fishiu commented Oct 31, 2024

/assign

@lance6716 lance6716 assigned lance6716 and unassigned fishiu Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ddl This issue is related to DDL of TiDB. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants