Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txn: add a variable to control whether to lock unchanged unique keys #44714

Closed
ekexium opened this issue Jun 15, 2023 · 0 comments · Fixed by #44598
Closed

txn: add a variable to control whether to lock unchanged unique keys #44714

ekexium opened this issue Jun 15, 2023 · 0 comments · Fixed by #44598
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.

Comments

@ekexium
Copy link
Contributor

ekexium commented Jun 15, 2023

Enhancement

#42210 and #42713 introduced the behavior of locking unchanged unique keys in INSERT IGNORE/REPLACE/UPDATE statements.
Locking more keys leads to higher TiKV load and a higher possibility of lock contention.
The performance impact may unexpectedly annoy performance-sensitive applications when they upgrade from an older version. We'd better add a switch to control the behavior.
@ekexium ekexium added type/bug The issue is confirmed as a bug. type/enhancement The issue or PR belongs to an enhancement. severity/major affects-7.1 This bug affects the 7.1.x(LTS) versions. labels Jun 15, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Jun 15, 2023
@ekexium ekexium mentioned this issue Jun 15, 2023
Merged
12 tasks
@ekexium ekexium added affects-6.5 This bug affects the 6.5.x(LTS) versions. sig/transaction SIG:Transaction and removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 type/enhancement The issue or PR belongs to an enhancement. labels Jun 15, 2023
ti-chi-bot bot pushed a commit that referenced this issue Jun 26, 2023
@ekexium
txn: add a variable to control whether to lock unchanged unique keys (#…
3c45737 
…44598)

close #44714
This was referenced Jun 26, 2023
Closed
Merged
ti-chi-bot bot pushed a commit that referenced this issue Jun 26, 2023
@ti-chi-bot
txn: add a variable to control whether to lock unchanged unique keys (#…
38ef1f9 
…44598) (#44938)

close #44714
@cfzjywxk cfzjywxk mentioned this issue Jul 20, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/major sig/transaction SIG:Transaction type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

txn: add a variable to control whether to lock unchanged unique keys ekexium/tidb
1 participant
@ekexium