Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coprocessor streaming scans duplicated ranges #30207

Closed
you06 opened this issue Nov 29, 2021 · 2 comments
Closed

coprocessor streaming scans duplicated ranges #30207

you06 opened this issue Nov 29, 2021 · 2 comments
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.

Comments

@you06
Copy link
Contributor

you06 commented Nov 29, 2021

Bug Report

Found by comment.

1. Minimal reproduce step (Required)

  1. Add a failpoint in coprocessor streaming result handle.

    https://github.com/you06/tidb/blob/446238dbe70d9b98973d592eff789c4b75ad06d9/store/copr/coprocessor.go#L843-L851

  2. Enable failpoints, build TiDB and run the playground.

GO_FAILPOINTS="github.com/pingcap/tidb/store/copr/streamRecvErr=return(true)" tiup playground nightly --monitor=false --tiflash=0 --db.binpath=./tidb-server
  1. Prepare data with this script

  2. Connect to TiDB and run the following SQLs.

MySQL [test]> set session tidb_enable_streaming = 1;
Query OK, 0 rows affected (0.001 sec)

MySQL [test]> select * from t;
...

2. What did you expect to see? (Required)

The select SQL returns 1,000 rows.

3. What did you see instead (Required)

The select SQL may return more than 1,000 rows.

MySQL [test]> select * from t;
+-----+------+
| id  | v    |
+-----+------+
|   0 |    0 |
|   1 |    1 |
|   2 |    2 |
...
| 994 |  994 |
| 995 |  995 |
| 996 |  996 |
| 997 |  997 |
| 998 |  998 |
| 999 |  999 |
+-----+------+
1872 rows in set (5.250 sec)

4. What is your TiDB version? (Required)

Release Version: v5.4.0-alpha-227-gdde1e0bf0-dirty
Edition: Community
Git Commit Hash: dde1e0bf0484475f37b3f04f8a865285afbfcbe1
Git Branch: master
UTC Build Time: 2021-11-29 02:59:56
GoVersion: go1.17.3
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false
@you06 you06 added type/bug The issue is confirmed as a bug. sig/execution SIG execution labels Nov 29, 2021
@XuHuaiyu
Copy link
Contributor

I do not think this is a bug, we deprecate this config in #25906.
I'll change the label from bug to enhancement.

@XuHuaiyu XuHuaiyu added type/enhancement The issue or PR belongs to an enhancement. and removed type/bug The issue is confirmed as a bug. labels Nov 29, 2021
@you06
Copy link
Contributor Author

you06 commented Nov 30, 2021

#29612 made some reconstruction in review, this issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants