migrate test-infra to testify for ddl pkg

[tisonkun]

• migrate test-infra to testify for ddl/failtest pkg #27669
• migrate test-infra to testify for ddl/label pkg #27670
• migrate test-infra to testify for ddl/placement pkg #27671
• migrate test-infra to testify for ddl/util pkg #27672
• migrate test-infra to testify for ddl/attributes_sql_test.go #28628
• migrate test-infra to testify for ddl/callback_test.go #28629
• migrate test-infra to testify for ddl/column_change_test.go #28630
• migrate test-infra to testify for ddl/column_test.go #28631
• migrate test-infra to testify for ddl/column_type_change_test.go #28632
• migrate test-infra to testify for ddl/db_cache_test.go #30086
• migrate test-infra to testify for ddl/db_change_test.go #28633
• migrate test-infra to testify for ddl/db_integration_test.go #28634
• migrate test-infra to testify for ddl/db_partition_test.go #28635
• migrate test-infra to testify for ddl/db_test.go #28636
• migrate test-infra to testify for ddl/ddl_algorithm_test.go #28637
• migrate test-infra to testify for ddl/ddl_test.go #28638
• migrate test-infra to testify for ddl/ddl_worker_test.go #28639
• migrate test-infra to testify for ddl/fail_test.go #29102
• migrate test-infra to testify for ddl/foreign_key_test.go #29103
• migrate test-infra to testify for ddl/index_change_test.go #29104
• migrate test-infra to testify for ddl/options_test.go #29105
• migrate test-infra to testify for ddl/partition_test.go #29106
• migrate test-infra to testify for ddl/placement_sql_test.go #29107
• migrate test-infra to testify for ddl/reorg_test.go #29108
• migrate test-infra to testify for ddl/restart_test.go #29109
• migrate test-infra to testify for ddl/rollingback_test.go #29110
• migrate test-infra to testify for ddl/schema_test.go #29111
• migrate test-infra to testify for ddl/sequence_test.go #29112
• migrate test-infra to testify for ddl/serial_test.go #29113
• migrate test-infra to testify for ddl/stat_test.go #29114
• migrate test-infra to testify for ddl/table_split_test.go #29115
• migrate test-infra to testify for ddl/table_test.go #29116
• migrate test-infra to testify for ddl/ddl_tiflash_test.go #31844
• migrate test-infra to testify for ddl/primary_key_handle_test.go #32843

[karuppiah7890]

/assign

[tisonkun]

@karuppiah7890 glad to see you working on this!

ddl is one of our most complicated packages and domains. Even if we just do tests migration, I suggest you start from child package like ddl/label, ddl/placement, etc.

You can collaborate with me as how @yedamao did #27618 (comment) .

[karuppiah7890]

Sure! Thanks @tisonkun ! I did think that this might be a hard one, looking at no one assigned themselves to it yet. I was planning on checking the package today to understand if it needs more subtasks, as I noticed more sub tasks for other issues. Looks like it does. I'll start from small packages that you mentioned 👍

I'll also note down all the test files and sub packages so that we can create sub tasks? Either GitHub issues or put a list in this issue as task list

[tisonkun]

I'll also note down all the test files and sub packages so that we can create sub tasks? Either GitHub issues or put a list in this issue as task list

Either #27618 (comment) or #27142 (comment) is ok for me.

[karuppiah7890]

Hoping we won't have too much complex things to comment in the GitHub issues, I'll choose to create just subtasks here for now for easy managment instead of creating too many GitHub issues. But yeah, while creating PRs, we can't close this issue with Fixes #.... Let's see. First let me create a list like this - #27142 (comment)

[karuppiah7890]

Ah, #27142 (comment) also has subtasks as GitHub issues, okay!

[tisonkun]

@karuppiah7890 I created issues for all child packages. For files, I'd like to postpone a bit until you'd actually work on it. Maybe follow #27618 (comment) and ask me to update the description, or ask me to create the issues.

[karuppiah7890]

I removed my assignment @tisonkun

[AR10X]

I would like to contribute. But I would appreciate it if you help me with how to tackle this issue.

[karuppiah7890]

I think @tisonkun can help find a good first issue among the sub issues of this issue. Some of them are already marked as good first issue, but I'm not sure, I'll have to look at it to understand complexity etc, and I think @tisonkun has more context

[AR10X]

Thank you @tisonkun 😄. I will also look at issues see which one I can tackle.

[tisonkun]

@zimulala @tangenta I just notice that many tests under ddl package are tightly coupled and hardly break down to deal with one by one. Could you please take a look?

[hawkingrei]

Please add #30086 to the issue description.

[hawkingrei]

@zimulala @tangenta I just notice that many tests under ddl package are tightly coupled and hardly break down to deal with one by one. Could you please take a look?

OK, I will.

[tisonkun]

Please add #30086 to the issue description.

Updated.

[Adam-Kulju]

@tisonkun Migrating schema_test, stat_test, and table_test to testify all spill over into restart_test so those will all have to be done at once I think. I'm working on them right now, hopefully restart_test won't end up spilling over into even more tests (if that's the case I'll probably give up).
Edit: Sadly, touching table_test affects almost every other test file, and I am quite certain migrating all of those at once is beyond my abilities to do. I'll look for some other ones that aren't quite as dependent.

@karuppiah7890 I created issues for all child packages. For files, I'd like to postpone a bit until you'd actually work on it. Maybe follow #27618 (comment) and ask me to update the description, or ask me to create the issues.

[GOODBOY008]

Hi,@tisonkun . testkit.go and testkit_test.go should migrate test-infra to testify too.

[tisonkun]

@GOODBOY008 I don't know what you mean. There is no such file in ddl package. If you mean that in util/testkit folder, please see its successors in testkit folder.

Also, existing migration examples should help.

[GOODBOY008]

@tisonkun I got it.Thanks your patience explanation!

[xhebox]

#31844 is added to the task list, which is introduced by tiflash guys.

[tisonkun]

Finally we finish it! Closed as all subtasks resolved.