Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for table/tables #26866

Closed
3 tasks done
Tracked by #26022
tisonkun opened this issue Aug 3, 2021 · 3 comments · Fixed by #27902
Closed
3 tasks done
Tracked by #26022

migrate test-infra to testify for table/tables #26866

tisonkun opened this issue Aug 3, 2021 · 3 comments · Fixed by #27902
Assignees
@feitian124
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2021 •
edited
Loading

You may try to analyze first and spawn more subtasks on demand (no strict) instead of one big PR handle the whole package which is hard to review.

There may be several unstable tests, be careful or you may try to fix it. If not, keep logic as is.
@tisonkun tisonkun mentioned this issue Aug 3, 2021
Closed
53 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 3, 2021
@feitian124
Copy link
Contributor

/assign

@feitian124 feitian124 mentioned this issue Aug 24, 2021
Merged
3 tasks
@feitian124
Copy link
Contributor

feitian124 commented Aug 25, 2021 •
edited
Loading

Please add #27557 as subtask of this issue.

@tisonkun
Copy link
Contributor Author

tisonkun commented Aug 25, 2021 •
edited
Loading

@feitian124 updated. You can assign the subtask to yourself.

@feitian124 feitian124 mentioned this issue Sep 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feitian124 feitian124

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

table/tables: migrate test-infra to testify for tables_test.go feitian124/tidb
2 participants
@feitian124 @tisonkun