Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for util/logutil pkg #26154

Closed
Tracked by #33453
tisonkun opened this issue Jul 12, 2021 · 4 comments · Fixed by #26322
Closed
Tracked by #33453

migrate test-infra to testify for util/logutil pkg #26154

tisonkun opened this issue Jul 12, 2021 · 4 comments · Fixed by #26322
Assignees
@ofey404
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

No description provided.

@tisonkun tisonkun mentioned this issue Jul 12, 2021
Closed
53 tasks
@tisonkun
Copy link
Contributor Author

Assignee may take a look at pingcap/log#16 and see how to make log tests

@tisonkun tisonkun added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 13, 2021
@ofey404
Copy link
Contributor

ofey404 commented Jul 18, 2021

Hi @tisonkun, I'd like to migrate tests under util/logutil pkg. Please create a subtask and assign to me ;)

Cloned pingcap/log#16, I think I understand how log test works now XD

@tisonkun
Copy link
Contributor Author

/assign @ofey404

Thanks for taking this issue. Go ahead!

@ofey404 ofey404 mentioned this issue Jul 18, 2021
Merged
@tisonkun
Copy link
Contributor Author

tisonkun commented Jul 18, 2021 •
edited
Loading

@ofey404 before writing code, you are suggested to take a look at PRs merged already and keep consistent code style. Thanks!

@ti-srebot ti-srebot mentioned this issue Sep 17, 2021
Merged
@tisonkun tisonkun mentioned this issue Mar 25, 2022
Closed
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ofey404 ofey404

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

util/logutil: migrate to testify ofey404/tidb
2 participants
@tisonkun @ofey404