Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test github.com/pingcap/tidb/planner/core FAIL but all case PASS #19802

Closed
lance6716 opened this issue Sep 4, 2020 · 8 comments
Closed
Labels
challenge-program help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@lance6716
Copy link
Contributor

lance6716 commented Sep 4, 2020

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

pingcap/parser#1008 ⬅️ seems stable reproduce, others:

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/48200/pipeline/69/

https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/48303/pipeline/73/

2. What did you expect to see? (Required)

PASS or FAIL and indicate which case FAIL

3. What did you see instead (Required)

FAIL github.com/pingcap/tidb/planner/core 25.684s

and all other is PASS

4. What is your TiDB version? (Required)

current master

SIG slack channel

#sig-planner

Score

  • 300

Mentor

@lance6716 lance6716 added the type/bug The issue is confirmed as a bug. label Sep 4, 2020
@lance6716
Copy link
Contributor Author

/label planner

@ti-srebot
Copy link
Contributor

These labels are not found planner.

@lance6716
Copy link
Contributor Author

/label sig/planner

@ti-srebot ti-srebot added the sig/planner SIG: Planner label Sep 4, 2020
@lance6716
Copy link
Contributor Author

lance6716 commented Sep 5, 2020

run a local test (passed as expected) and compare output with https://internal.pingcap.net/idc-jenkins/blue/organizations/jenkins/tidb_ghpr_unit_test/detail/tidb_ghpr_unit_test/48303/pipeline/73/, found these test not printed

PASS: prepare_test.go:49: testPrepareSerialSuite.TestPrepareCache	
PASS: prepare_test.go:395: testPrepareSerialSuite.TestPrepareCacheForPartition	
PASS: prepare_test.go:135: testPrepareSerialSuite.TestPrepareCacheIndexScan	
PASS: prepare_test.go:217: testPrepareSerialSuite.TestPrepareCacheNow	
PASS: prepare_test.go:245: testPrepareSerialSuite.TestPrepareOverMaxPreparedStmtCount	
PASS: prepare_test.go:295: testPrepareSerialSuite.TestPrepareTableAsNameOnGroupByWithCache	

and with https://app.circleci.com/pipelines/github/pingcap/parser/3634/workflows/2dec2f19-6b45-4514-93cf-bf052574ece7/jobs/6581, these test not printed

PASS: prepare_test.go:217: testPrepareSerialSuite.TestPrepareCacheNow	
PASS: prepare_test.go:245: testPrepareSerialSuite.TestPrepareOverMaxPreparedStmtCount	
PASS: prepare_test.go:295: testPrepareSerialSuite.TestPrepareTableAsNameOnGroupByWithCache	

and these's export log_level=fatal before run tests, not sure it will affect FAIL tests printing

@lance6716
Copy link
Contributor Author

not printed:

PASS: prepare_test.go:135: testPrepareSerialSuite.TestPrepareCacheIndexScan	
PASS: prepare_test.go:217: testPrepareSerialSuite.TestPrepareCacheNow	
PASS: prepare_test.go:245: testPrepareSerialSuite.TestPrepareOverMaxPreparedStmtCount	
PASS: prepare_test.go:295: testPrepareSerialSuite.TestPrepareTableAsNameOnGroupByWithCache

@lzmhhh123 lzmhhh123 added challenge-program help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 30, 2020
@yudongusa
Copy link

@lance6716 would you please verify if the issue still exists? If not, please help to close this issue.

@lance6716
Copy link
Contributor Author

I haven't focused on TiDB's CI these days, so not sure if it has been fixed. We might close it as well 😄

@ti-srebot
Copy link
Contributor

Please edit this comment or add a new comment to complete the following information

Not a bug

  1. Remove the 'type/bug' label
  2. Add notes to indicate why it is not a bug

Duplicate bug

  1. Add the 'type/duplicate' label
  2. Add the link to the original bug

Bug

Note: Make Sure that 'component', and 'severity' labels are added
Example for how to fill out the template: #20100

1. Root Cause Analysis (RCA) (optional)

2. Symptom (optional)

3. All Trigger Conditions (optional)

4. Workaround (optional)

5. Affected versions

6. Fixed versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge-program help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

5 participants