Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support LIST COLUMNS partitioning #18052

Closed
lysu opened this issue Jun 16, 2020 · 3 comments
Closed

Support LIST COLUMNS partitioning #18052

lysu opened this issue Jun 16, 2020 · 3 comments
Labels
feature/accepted This feature request is accepted by product managers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/compatibility type/feature-request Categorizes issue or PR as related to a new feature.

Comments

@lysu
Copy link
Contributor

lysu commented Jun 16, 2020

Feature Request

Is your feature request related to a problem? Please describe:

MySQL support LIST COLUMNS partition but TiDB didn't support it now.

support it will help mysql user migrate to TiDB

Describe the feature you'd like:

Compatible with MySQL's LIST COLUMNS partition

Describe alternatives you've considered:

n/a

Teachability, Documentation, Adoption, Migration Strategy:

@lysu lysu added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/compatibility type/feature-request Categorizes issue or PR as related to a new feature. labels Jun 16, 2020
@scsldb scsldb changed the title support LIST COLUMNS partitioning Support LIST COLUMNS partitioning Jul 16, 2020
@scsldb scsldb added the feature/reviewing This feature request is reviewing by product managers label Jul 16, 2020
@zz-jason zz-jason added feature/discussing This feature request is discussing among product managers and removed feature/reviewing This feature request is reviewing by product managers labels Aug 10, 2020
@zz-jason
Copy link
Member

list partition is useful in the geo-partition scenario. take the following table (from LIST COLUMNS partitioning - MySQL) as an example:

CREATE TABLE customers (
    first_name VARCHAR(25),
    last_name VARCHAR(25),
    street_1 VARCHAR(30),
    street_2 VARCHAR(30),
    city VARCHAR(15),
    renewal DATE
)

PARTITION BY LIST COLUMNS(city) (
    PARTITION pRegion_1 VALUES IN('Oskarshamn', 'Högsby', 'Mönsterås'),
    PARTITION pRegion_2 VALUES IN('Vimmerby', 'Hultsfred', 'Västervik'),
    PARTITION pRegion_3 VALUES IN('Nässjö', 'Eksjö', 'Vetlanda'),
    PARTITION pRegion_4 VALUES IN('Uppvidinge', 'Alvesta', 'Växjo')
);

with placement rules (#18030), we can define a location constraint for each partition to achieve better read/write performance.

@zz-jason zz-jason added feature/accepted This feature request is accepted by product managers and removed feature/discussing This feature request is discussing among product managers labels Aug 10, 2020
@zz-jason zz-jason removed their assignment Aug 10, 2020
@zz-jason
Copy link
Member

@crazycs520 PTAL

@crazycs520
Copy link
Contributor

Should be supported in #20279

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/accepted This feature request is accepted by product managers help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/compatibility type/feature-request Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants