Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should rewrite the ddl_query in binlog if split the ddl_query into multi ddl job #11410

Closed
july2993 opened this issue Jul 24, 2019 · 3 comments
Closed
Assignees
Labels
component/binlog component/tools severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug. type/stale This issue has not been updated for a long time.

Comments

@july2993
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do?
    If possible, provide a recipe for reproducing the error.
    create table a(id int);
    create table b(id int);
    drop table a,b;

  2. What did you expect to see?
    receive two ddl binlog, one is drop table a, one is drop table b

  3. What did you see instead?
    receive two ddl binlog, both ddl_query is drop table a, b

in

func (e *DDLExec) executeDropTableOrView(s *ast.DropTableStmt) error {

it will run one ddl job for one table, but the ddl_query is the origin query drop table a,b

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?
| Release Version: v3.0.0-rc.1-339-g368119b8d
Git Commit Hash: 368119b8df10d65a7575a90de8d77def660ac5ca
Git Branch: master
UTC Build Time: 2019-07-19 07:22:03
GoVersion: go version go1.12.5 darwin/amd64
Race Enabled: false
TiKV Min Version: 2.1.0-alpha.1-ff3dd160846b7d1aed9079c389fc188f7f5ea13e
Check Table Before Drop: false |
@bb7133
Copy link
Member

bb7133 commented Aug 27, 2020

Confirmed that this issue doesn't lead to an incorrect result, we'll try to make drop tables atomic, as what is changed in MySQL 8(https://dev.mysql.com/doc/refman/8.0/en/atomic-ddl.html)

@wjhuang2016
Copy link
Member

@july2993 Because it doesn't lead to an incorrect result, we don't have a plan to fix this issue. Can we mark it as won't fix and close?

@jebter
Copy link

jebter commented Jul 4, 2024

"Starting from TiDB v7.5.0, technical support for the data replication feature of TiDB Binlog is no longer provided. It is strongly recommended to use TiCDC as an alternative solution for data replication." refer:https://docs.pingcap.com/tidb/dev/tidb-binlog-overview
The issue has not been updated for too long, so I will close it. If there are any updates, you can reopen it.

@jebter jebter closed this as completed Jul 4, 2024
@jebter jebter added the type/stale This issue has not been updated for a long time. label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/binlog component/tools severity/minor sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug. type/stale This issue has not been updated for a long time.
Projects
None yet
Development

No branches or pull requests

8 participants