-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support "SHOW PROCESSLIST MEMINFO" #10199
Comments
@ngaut It actually was on |
Great, let's make it work properly. |
We can trace memory usage in distsql now. It's much precise than before. However the memory info for some simple statements can still be zero. Because they are not memory intensive queries. I think we can optimize it in these ways:
|
Why don't we just add a column to information_schema.processlist instead of fooling around w/ extra SHOW PROCESSLIST syntax? I worry that adding columns to SHOW PROCESSLIST output might break some tools, while I think it's probably safer to add things to information_schema.processlist. |
+1 to @kolbe's suggestion. It is easier to extend |
@morgo, @kolbe To summary, the refinements we should do are:
Am I right? If so, @SunRunAway is going to address this issue. |
I think we should only do #1 (add a column to |
….processlist (pingcap#10837) *: add a column describing memory usage for table information_schema.processlist Closes pingcap#10199 Conflicts: executor/show.go infoschema/tables.go infoschema/tables_test.go util/misc_test.go util/processinfo.go
…processlist (pingcap#10837) *: add a column describing memory usage for table information_schema.processlist Closes pingcap#10199 Conflicts: executor/show.go infoschema/tables.go infoschema/tables_test.go util/misc_test.go util/processinfo.go
Feature Request
Is your feature request related to a problem? Please describe:
In #8543, we removed the memory info from the result of
show processlist
. As discussed in #8543 (comment), we decide to add a new command likeshow processlist meminfo
to show the process lists + meminfoDescribe the feature you'd like:
use
show processlist meminfo
to show the result of process lists and meminfoDescribe alternatives you've considered:
No
Teachability, Documentation, Adoption, Migration Strategy:
No
The text was updated successfully, but these errors were encountered: