Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zone labels and kubelet reserved memories for GCP and Alibaba Cloud #891

Closed
2 tasks
aylei opened this issue Sep 9, 2019 · 4 comments
Closed
2 tasks

Zone labels and kubelet reserved memories for GCP and Alibaba Cloud #891

aylei opened this issue Sep 9, 2019 · 4 comments
Labels

Comments

@aylei
Copy link
Contributor

aylei commented Sep 9, 2019

Feature Request

#848 #845 add zone label and customization of kubelet args support for AWS, these should also be implemented for the GCP and Alibaba Cloud.

This issue is created to track the progress:

  • Alibaba Cloud
  • GCP

Is your feature request related to a problem? Please describe:

see original issues for detail.

@aylei aylei added area/terraform good first issue Good for newcomers status/help-wanted Extra attention is needed labels Sep 9, 2019
@gregwebs
Copy link
Contributor

gregwebs commented Sep 9, 2019

can tidb-operator do some translation on the slash? Or add the label as an annotation? Then we can solve this in the operator once without having to figure out this setup for every K8s.

@aylei
Copy link
Contributor Author

aylei commented Sep 10, 2019

@gregwebs Yes, I suggested these methods before and we thought it's better to tolerate the slash on the PD side to avoid adding indirections and this fix has landed in the new versions of PD (tikv/pd@d91268e).

So this is a workaround for old versions.

@gregwebs
Copy link
Contributor

@aylei can we get this fix in the next PD point release?

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants