Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable static library #71

Open
wants to merge 2 commits into
base: raftstore-proxy-6.1
Choose a base branch
from

Conversation

SchrodingerZhu
Copy link

Signed-off-by: Schrodinger ZHU Yifan [email protected]

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Signed-off-by: Schrodinger ZHU Yifan <[email protected]>
@SchrodingerZhu SchrodingerZhu requested a review from CalvinNeo May 30, 2022 06:21
@CalvinNeo
Copy link
Member

CalvinNeo commented May 30, 2022

Could you please redirect this PR to branch raftstore-proxy? This branch is "master branch" of tidb-engine-ext

Sorry, there are some problems about branches, I will check that first.

@@ -20,7 +20,14 @@ else
echo "rust build-std is disabled"
fi

lib_suffix="so"
RAFTSTORE_PROXY_ENABLE_STATIC="${RAFTSTORE_PROXY_ENABLE_STATIC:-0}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants