Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce only-decryption mode #118

Merged
merged 1 commit into from
Jul 5, 2022
Merged

introduce only-decryption mode #118

merged 1 commit into from
Jul 5, 2022

Conversation

hehechen
Copy link

@hehechen hehechen commented Jul 4, 2022

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#5122

Problem Summary:

What is changed and how it works?

TiFlash Proxy introduce only-decryption mode. If TiFlash set --only-decryption, TiFlash Proxy will not startup TiKV server.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    ./bin/tiflash/tiflash pagectl -V 3 -P /data2/chentongli/tidb-data/tiflash-19111/page/meta -I 0 --config_file_path conf/tiflash.toml
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@hehechen hehechen requested a review from CalvinNeo July 4, 2022 03:21
@hehechen hehechen force-pushed the raftstore-proxy-6.2 branch 2 times, most recently from 98dc546 to 3a50e1f Compare July 4, 2022 09:11
@hehechen hehechen force-pushed the raftstore-proxy-6.2 branch from 3a50e1f to 8572836 Compare July 5, 2022 02:43
CalvinNeo
CalvinNeo approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@CalvinNeo CalvinNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CalvinNeo CalvinNeo merged commit 6ea4d60 into pingcap:raftstore-proxy-6.2 Jul 5, 2022
@hehechen hehechen mentioned this pull request Jul 5, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinNeo CalvinNeo CalvinNeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hehechen @CalvinNeo