Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drainer: escape quote in value of column #1132

Merged
merged 2 commits into from
Jan 21, 2022
Merged

drainer: escape quote in value of column #1132

merged 2 commits into from
Jan 21, 2022

Conversation

cartersz
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #1131

What is changed and how it works?

escape single quote.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

  • No release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 20, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • lichunzhu

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@cartersz
Copy link
Contributor Author

/run-all-tests

lichunzhu
lichunzhu reviewed Jan 20, 2022
View reviewed changes
pkg/loader/model.go Outdated
}
}

func processOracleQuoteStringValue(data string) string {
return strings.Replace(data, "'", "''", -1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return strings.Replace(data, "'", "''", -1)
return strings.ReplaceAll(data, "'", "''")

@cartersz
Copy link
Contributor Author

/run-all-tests

2 similar comments
@cartersz
Copy link
Contributor Author

/run-all-tests

@cartersz
Copy link
Contributor Author

/run-all-tests

@CLAassistant
Copy link

CLAassistant commented Jan 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cartersz
Copy link
Contributor Author

/run-all-tests

@lichunzhu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ad8270e

@ti-chi-bot ti-chi-bot merged commit b607f34 into pingcap:master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu lichunzhu approved these changes

@glorv glorv glorv approved these changes

Assignees
No one assigned
Labels
size/XS status/can-merge status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cartersz @ti-chi-bot @CLAassistant @lichunzhu @glorv