server: fix WaitGroup data race #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rleungx
force-pushed
the
fix-wg-data-race
branch
from
edcf7fa to
a1e75fb
Compare
disksing
approved these changes
Oct 16, 2018
disksing
added
the
needs-cherry-pick-release-2.1
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Oct 23, 2018
disksing
pushed a commit
that referenced
this pull request
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
At present,
coordinatorusesWaitGroupto synchronize. We callAdd()in(c *coordinator) run()andWait()in(c *coordinator) stop()which are in different goroutines. So the data race could happen when the leader drops. This PRs closes #1268.What is changed and how it works?
Check List
Tests
make test)Related changes