*: bump grpc to 1.12.2 #1265
Merged
*: bump grpc to 1.12.2 #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolouch
approved these changes
Oct 10, 2018
|
/run-all-tests |
gregwebs
reviewed
Oct 11, 2018
| @@ -18,7 +18,7 @@ | |||
| [[constraint]] | |||
| name = "google.golang.org/grpc" | |||
| source = "https://github.com/grpc/grpc-go.git" | |||
| version = "1.12.0" | |||
There was a problem hiding this comment.
Why do we use "source =" for this package?
There was a problem hiding this comment.
I think the reason is go-grpc's import path is different from its source path.
There was a problem hiding this comment.
The package contains all the source needed though, so you should be able to delete the "source" line.
disksing
added
the
needs-cherry-pick-release-2.1
rleungx
added a commit
to rleungx/pd
that referenced
this pull request
Oct 23, 2018
disksing
pushed a commit
that referenced
this pull request
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Closes #1264.
What is changed and how it works?
This PR bumps the version fo grpc to 1.12.2 in order to fix the data race problem.
Check List
Tests