parser: more meaningful words for placement rules #931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #931 +/- ##
=======================================
Coverage 78.46% 78.46%
=======================================
Files 40 40
Lines 14913 14913
=======================================
Hits 11701 11701
Misses 2521 2521
Partials 691 691 |
zimulala
reviewed
Jul 16, 2020
ti-srebot
previously approved these changes
Jul 21, 2020
|
@xhebox |
follow pingcap/tidb#18030 (comment). However, "constraints" is used for "label". Because it is not necessarily related to region/locality.
|
@zimulala Resolved. Please give another approved. |
kennytm
approved these changes
Jul 22, 2020
|
Should we update the RPC documents? cc @djshow832 |
|
@nolouch RFC documents are slower than my contribution progress until today. The syntax just changed again. Still, there are lots of things not decided. And there may be more problems on RFC documents when I am trying to implement this project. The conclusion is that just comment any inconsistency or problem on documents... |
|
@xhebox got it, thanks. |
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
follow pingcap/tidb#18030 (comment). However, "constraints" is used for "label". Because it is not necessarily related to region/locality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Follow pingcap/tidb#18030 (comment).
However, "constraints" is used for "label". Because it is not necessarily related to region/locality.
Check List
Tests
Code changes
Related changes