Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support new placement rules syntax #1299

Merged
merged 4 commits into from
Aug 18, 2021
Merged

*: support new placement rules syntax #1299

merged 4 commits into from
Aug 18, 2021

Conversation

xhebox
Copy link
Contributor

@xhebox xhebox commented Aug 6, 2021

What problem does this PR solve?

The syntax part for pingcap/tidb#26581. One extra change: constraints is moved from unreserved to notkeywords, since mysql does not have such keyword.

Check List

Tests

  • Unit test
  • Integration test

Code changes

  • Has exported variable/fields change

Related changes

  • Need to be included in the release note

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • morgo

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@xhebox xhebox requested a review from morgo August 6, 2021 05:25
@xhebox xhebox mentioned this pull request Aug 6, 2021
Closed
7 tasks
morgo
morgo reviewed Aug 6, 2021
View reviewed changes
parser.y Show resolved Hide resolved
AilinKid
AilinKid reviewed Aug 9, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

parser.y Outdated Show resolved Hide resolved
ast/ddl.go Outdated Show resolved Hide resolved
@AilinKid AilinKid mentioned this pull request Aug 11, 2021
Closed
@xhebox xhebox marked this pull request as ready for review August 16, 2021 05:40
@xhebox xhebox requested review from AilinKid and morgo August 16, 2021 05:42
@AilinKid
Copy link
Contributor

AilinKid commented Aug 16, 2021 •
edited
Loading

Screenshot_20210816_172122

Kenny has some suggestions with my draft PR (in fact on your base), PTAL

@xhebox
Copy link
Contributor Author

xhebox commented Aug 16, 2021 •
edited
Loading

Screenshot_20210816_172122

Kenny has some suggestions with my draft PR (in fact on your base), PTAL

It is already addressed.

@AilinKid
Copy link
Contributor

sure, better make parser again to resolve the conflicts

@ti-chi-bot ti-chi-bot added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels Aug 18, 2021
@xhebox
Copy link
Contributor Author

xhebox commented Aug 18, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 21dce69

@ti-chi-bot ti-chi-bot merged commit 26f5859 into pingcap:master Aug 18, 2021
@AilinKid AilinKid mentioned this pull request Aug 18, 2021
Merged
This was referenced Sep 7, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid approved these changes

@morgo morgo morgo approved these changes

Assignees
No one assigned
Labels
status/can-merge status/LGT2 LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xhebox @ti-chi-bot @AilinKid @morgo