From d73adca013e000761197f5c89353cf449c00de16 Mon Sep 17 00:00:00 2001 From: shichun-0415 Date: Wed, 16 Nov 2022 20:38:28 +0800 Subject: [PATCH 01/13] add 5.3.4 release notes --- TOC.md | 1 + releases/release-5.3.4.md | 151 +++++++++++++++++++++++++++++++++++ releases/release-notes.md | 1 + releases/release-timeline.md | 1 + 4 files changed, 154 insertions(+) create mode 100644 releases/release-5.3.4.md diff --git a/TOC.md b/TOC.md index e68ef2793085f..74606bafb84c9 100644 --- a/TOC.md +++ b/TOC.md @@ -916,6 +916,7 @@ - [5.4.1](/releases/release-5.4.1.md) - [5.4.0](/releases/release-5.4.0.md) - v5.3 + - [5.3.4](/releases/release-5.3.4.md) - [5.3.3](/releases/release-5.3.3.md) - [5.3.2](/releases/release-5.3.2.md) - [5.3.1](/releases/release-5.3.1.md) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md new file mode 100644 index 0000000000000..463de6e67542e --- /dev/null +++ b/releases/release-5.3.4.md @@ -0,0 +1,151 @@ +--- +title: TiDB 5.3.4 Release Note +--- + +# TiDB 5.3.4 Release Note + +Release date: xx, xx, 2022 + +TiDB version: 5.3.4 + +## Compatibility changes + +## Improvements + ++ TiDB + + + + + + + + + ++ TiKV + + + + - (dup) Reload TLS certificate automatically for each update to improve availability [#12546](https://github.com/tikv/tikv/issues/12546) + ++ PD + + + ++ TiFlash + + + + + ++ Tools + + + Backup & Restore (BR) + + + + + Dumpling + + + + + TiCDC + + + + + TiDB Binlog + + + + + TiDB Lightning + + + + + TiDB Data Migration (DM) + + + +## Bug fixes + ++ TiDB + + + + - (dup) Fix the issue that the Region cache is not cleaned up in time when the Region is merged[#37141](https://github.com/pingcap/tidb/issues/37141) + - (dup) Fix the issue that TiDB writes wrong data due to the wrong encoding of the ENUM or SET column [#32302](https://github.com/pingcap/tidb/issues/32302) + - (dup) Fix the issue that database-level privileges are incorrectly cleaned up [#38363](https://github.com/pingcap/tidb/issues/38363) + - (dup) Fix the issue that the `grantor` field is missing in the `mysql.tables_priv` table [#38293](https://github.com/pingcap/tidb/issues/38293) + - (dup) Fix the issue that `KILL TIDB` cannot take effect immediately on idle connections [#24031](https://github.com/pingcap/tidb/issues/24031) + - change date_add and date_sub string_(int/string/real/decimal) function return type to string [#36394](https://github.com/pingcap/tidb/issues/36394) + - fix(parser): restore table option INSERT_METHOD should use WriteKeyWord [#38368](https://github.com/pingcap/tidb/issues/38368) + - fix authentication with MySQL 5.1 and older clients [#29725](https://github.com/pingcap/tidb/issues/29725) + + + + - (dup) Fix wrong results of `GREATEST` and `LEAST` when passing in unsigned `BIGINT` arguments [#30101](https://github.com/pingcap/tidb/issues/30101) + - (dup) Fix the issue that the result of `concat(ifnull(time(3))` in TiDB is different from that in MySQL [#29498](https://github.com/pingcap/tidb/issues/29498) + - avoid sum from avg overflow [#29952](https://github.com/pingcap/tidb/issues/29952) + - add an unit test case for unreasonable invoking Close [#30587](https://github.com/pingcap/tidb/issues/27125) + - HashJoinExec checks the buildError even if the probeSide is empty [#30289](https://github.com/pingcap/tidb/issues/30289) + - expression: resize the result for IfXXSig [#37414](https://github.com/pingcap/tidb/issues/37414) + - change date_add and date_sub string_(int/string/real/decimal) function return type to string. [#27573](https://github.com/pingcap/tidb/issues/27573) + - fix hashjoin goleak [#39026](https://github.com/pingcap/tidb/issues/39026) + - fix: the results of tikv and tiflash are different [#37258](https://github.com/pingcap/tidb/issues/37258) + + + + + + - (dup) Fix the issue that the EXECUTE might throw an unexpected error in specific scenarios [#37187](https://github.com/pingcap/tidb/issues/37187) + - (dup) Fix the issue that `GROUP CONCAT` with `ORDER BY` might fail when the `ORDER BY` clause contains a correlated subquery [#18216](https://github.com/pingcap/tidb/issues/18216) + - Fix the issue that set wrong length and width for Decimal and Real when using plan-cache [#29565](https://github.com/pingcap/tidb/issues/29565) + - add an unit test case for unreasonable invoking Close [#27125](https://github.com/pingcap/tidb/issues/27125) + ++ TiKV + + + ++ PD + + + + - (dup) Fix the issue that PD cannot correctly handle dashboard proxy requests [#5321](https://github.com/tikv/pd/issues/5321) + - (dup) Fix the issue that the TiFlash learner replica might not be created [#5401](https://github.com/tikv/pd/issues/5401) + - (dup) Fix inaccurate Stream timeout and accelerate leader switchover [#5207](https://github.com/tikv/pd/issues/5207) + ++ TiFlash + + + + - fix: the results of tikv and tiflash are different [#5849](https://github.com/pingcap/tiflash/issues/5849) + - fix inconsistent result before deleting some rows [#6127](https://github.com/pingcap/tiflash/issues/6127) + + + + - Fix an invalid default value cause bootstrap failed [#3157](https://github.com/pingcap/tiflash/issues/3157) ++ Tools + + + Backup & Restore (BR) + + + + + Dumpling + + + + + TiCDC + + + + - use white list for retryable error [#6698](https://github.com/pingcap/tiflow/issues/6698) + + + TiDB Binlog + + + + + TiDB Lightning + + + + + TiDB Data Migration (DM) + + diff --git a/releases/release-notes.md b/releases/release-notes.md index 13b31c7ae3b75..ed741891c158a 100644 --- a/releases/release-notes.md +++ b/releases/release-notes.md @@ -32,6 +32,7 @@ aliases: ['/docs/dev/releases/release-notes/','/docs/dev/releases/rn/'] ## 5.3 +- [5.3.4](/releases/release-5.3.4.md): 2022-xx-xx - [5.3.3](/releases/release-5.3.3.md): 2022-09-14 - [5.3.2](/releases/release-5.3.2.md): 2022-06-29 - [5.3.1](/releases/release-5.3.1.md): 2022-03-03 diff --git a/releases/release-timeline.md b/releases/release-timeline.md index fa7a1e65c1d6c..3a4d0ce09b0c7 100644 --- a/releases/release-timeline.md +++ b/releases/release-timeline.md @@ -9,6 +9,7 @@ This document shows all the released TiDB versions in reverse chronological orde | Version | Release Date | | :--- | :--- | +| [5.3.4](/releases/release-5.3.4.md) | 2022-xx-xx | | [6.1.2](/releases/release-6.1.2.md) | 2022-10-24 | | [5.4.3](/releases/release-5.4.3.md) | 2022-10-13 | | [6.3.0-DMR](/releases/release-6.3.0.md) | 2022-09-30 | From 1f13603570fca2f73932080d3be3374e630e1af2 Mon Sep 17 00:00:00 2001 From: shichun-0415 <89768198+shichun-0415@users.noreply.github.com> Date: Fri, 18 Nov 2022 17:59:04 +0800 Subject: [PATCH 02/13] add bug fix notes for sql-infra and transaction Co-authored-by: Hangjie Mo --- releases/release-5.3.4.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index 463de6e67542e..275dc86e34617 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -75,9 +75,9 @@ TiDB version: 5.3.4 - (dup) Fix the issue that database-level privileges are incorrectly cleaned up [#38363](https://github.com/pingcap/tidb/issues/38363) - (dup) Fix the issue that the `grantor` field is missing in the `mysql.tables_priv` table [#38293](https://github.com/pingcap/tidb/issues/38293) - (dup) Fix the issue that `KILL TIDB` cannot take effect immediately on idle connections [#24031](https://github.com/pingcap/tidb/issues/24031) - - change date_add and date_sub string_(int/string/real/decimal) function return type to string [#36394](https://github.com/pingcap/tidb/issues/36394) - - fix(parser): restore table option INSERT_METHOD should use WriteKeyWord [#38368](https://github.com/pingcap/tidb/issues/38368) - - fix authentication with MySQL 5.1 and older clients [#29725](https://github.com/pingcap/tidb/issues/29725) + - Fix return type to string for `adddate` and `subdate` functions [#36394](https://github.com/pingcap/tidb/issues/36394) + - Fix restore table option `INSERT_METHOD` incompatible with MySQL [#38368](https://github.com/pingcap/tidb/issues/38368) + - Fix authentication with MySQL 5.1 and older clients [#29725](https://github.com/pingcap/tidb/issues/29725) @@ -92,6 +92,8 @@ TiDB version: 5.3.4 - fix: the results of tikv and tiflash are different [#37258](https://github.com/pingcap/tidb/issues/37258) + + - Fix the issue explain analyze with DML executors may respond to the client before the transaction commit has finished. [#37373](https://github.com/pingcap/tidb/issues/37373) From 9b0fd3e6e5791bd9752a157d96d60b2ae5ff6462 Mon Sep 17 00:00:00 2001 From: shichun-0415 <89768198+shichun-0415@users.noreply.github.com> Date: Mon, 21 Nov 2022 12:42:39 +0800 Subject: [PATCH 03/13] Apply suggestions from code review Co-authored-by: HuaiyuXu Co-authored-by: Xiaoju Wu --- releases/release-5.3.4.md | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index 275dc86e34617..0d777ee5e6623 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -83,13 +83,10 @@ TiDB version: 5.3.4 - (dup) Fix wrong results of `GREATEST` and `LEAST` when passing in unsigned `BIGINT` arguments [#30101](https://github.com/pingcap/tidb/issues/30101) - (dup) Fix the issue that the result of `concat(ifnull(time(3))` in TiDB is different from that in MySQL [#29498](https://github.com/pingcap/tidb/issues/29498) - - avoid sum from avg overflow [#29952](https://github.com/pingcap/tidb/issues/29952) - - add an unit test case for unreasonable invoking Close [#30587](https://github.com/pingcap/tidb/issues/27125) - - HashJoinExec checks the buildError even if the probeSide is empty [#30289](https://github.com/pingcap/tidb/issues/30289) - - expression: resize the result for IfXXSig [#37414](https://github.com/pingcap/tidb/issues/37414) - - change date_add and date_sub string_(int/string/real/decimal) function return type to string. [#27573](https://github.com/pingcap/tidb/issues/27573) - - fix hashjoin goleak [#39026](https://github.com/pingcap/tidb/issues/39026) - - fix: the results of tikv and tiflash are different [#37258](https://github.com/pingcap/tidb/issues/37258) + - Fix the issue that avg() returns error `ERROR 1105 (HY000): other error for mpp stream: Could not convert to the target type - -value is out of range.` when quering from TiFlash [#29952](https://github.com/pingcap/tidb/issues/29952) + - Fix the issue that sql returns `ERROR 1105 (HY000): close of nil channel` when using HashJoinExec [#30289](https://github.com/pingcap/tidb/issues/30289) + - Fix the different return type of date_add and date_sub between TiDB and MySQL. Change date_add and date_sub string_(int/string/real/decimal) function return type to string [#27573](https://github.com/pingcap/tidb/issues/27573) + - Fix the problem that tikv and tiflash return different results when query logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) @@ -99,8 +96,7 @@ TiDB version: 5.3.4 - (dup) Fix the issue that the EXECUTE might throw an unexpected error in specific scenarios [#37187](https://github.com/pingcap/tidb/issues/37187) - (dup) Fix the issue that `GROUP CONCAT` with `ORDER BY` might fail when the `ORDER BY` clause contains a correlated subquery [#18216](https://github.com/pingcap/tidb/issues/18216) - - Fix the issue that set wrong length and width for Decimal and Real when using plan-cache [#29565](https://github.com/pingcap/tidb/issues/29565) - - add an unit test case for unreasonable invoking Close [#27125](https://github.com/pingcap/tidb/issues/27125) + - Fix the issue that wrong length and width are set for Decimal and Real when using plan-cache [#29565](https://github.com/pingcap/tidb/issues/29565) + TiKV @@ -111,7 +107,7 @@ TiDB version: 5.3.4 - (dup) Fix the issue that PD cannot correctly handle dashboard proxy requests [#5321](https://github.com/tikv/pd/issues/5321) - - (dup) Fix the issue that the TiFlash learner replica might not be created [#5401](https://github.com/tikv/pd/issues/5401) + - (dup) Fix the issue that the TiFlash learner replica might not be created in specific scenarios [#5401](https://github.com/tikv/pd/issues/5401) - (dup) Fix inaccurate Stream timeout and accelerate leader switchover [#5207](https://github.com/tikv/pd/issues/5207) + TiFlash From fcccbc7923a166a8120a26b1189dab443ac54d7d Mon Sep 17 00:00:00 2001 From: shichun-0415 <89768198+shichun-0415@users.noreply.github.com> Date: Mon, 21 Nov 2022 17:52:50 +0800 Subject: [PATCH 04/13] Apply suggestions from code review Co-authored-by: HuaiyuXu Co-authored-by: Chunzhu Li --- releases/release-5.3.4.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index 0d777ee5e6623..e4ed56d298dd6 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -90,7 +90,8 @@ TiDB version: 5.3.4 - - Fix the issue explain analyze with DML executors may respond to the client before the transaction commit has finished. [#37373](https://github.com/pingcap/tidb/issues/37373) + - Fix the issue explain analyze with DML executors may respond to the client before the transaction commit has finished [#37373](https://github.com/pingcap/tidb/issues/37373) + - Fix the issue that the region cache after merging many regions is not cleared properly [#37174](https://github.com/pingcap/tidb/issues/37174) @@ -114,12 +115,11 @@ TiDB version: 5.3.4 - - fix: the results of tikv and tiflash are different [#5849](https://github.com/pingcap/tiflash/issues/5849) - - fix inconsistent result before deleting some rows [#6127](https://github.com/pingcap/tiflash/issues/6127) + - Fix the issue that logical operators return wrong results when the argument type is UInt8 [#6127](https://github.com/pingcap/tiflash/issues/6127) - - Fix an invalid default value cause bootstrap failed [#3157](https://github.com/pingcap/tiflash/issues/3157) + - Fix the issue that TiFlash crash due to using `0.0` as the integer's default value. E.g. `i` int(11) NOT NULL DEFAULT '0.0' [#3157](https://github.com/pingcap/tiflash/issues/3157) + Tools + Backup & Restore (BR) @@ -130,11 +130,12 @@ TiDB version: 5.3.4 + - Fix the issue that dumpling can't dump with `--compress` option and s3 output directory [#30534](https://github.com/pingcap/tidb/issues/30534) + TiCDC - - use white list for retryable error [#6698](https://github.com/pingcap/tiflow/issues/6698) + - Fix a issue that causes MySQL related error not reported to owner in time [#6698](https://github.com/pingcap/tiflow/issues/6698) + TiDB Binlog From 9e49ca2169c342756ae7f3d2d7b6eccd4b27b43a Mon Sep 17 00:00:00 2001 From: shichun-0415 Date: Mon, 21 Nov 2022 19:16:49 +0800 Subject: [PATCH 05/13] remove unnecessary parts --- releases/release-5.3.4.md | 76 +++------------------------------------ 1 file changed, 5 insertions(+), 71 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index e4ed56d298dd6..381df2cfdf7ab 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -8,62 +8,14 @@ Release date: xx, xx, 2022 TiDB version: 5.3.4 -## Compatibility changes - ## Improvements -+ TiDB - - - - - - - - - + TiKV - (dup) Reload TLS certificate automatically for each update to improve availability [#12546](https://github.com/tikv/tikv/issues/12546) -+ PD - - - -+ TiFlash - - - - - -+ Tools - - + Backup & Restore (BR) - - - - + Dumpling - - - - + TiCDC - - - - + TiDB Binlog - - - - + TiDB Lightning - - - - + TiDB Data Migration (DM) - - - ## Bug fixes + TiDB @@ -89,7 +41,7 @@ TiDB version: 5.3.4 - Fix the problem that tikv and tiflash return different results when query logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) - + - Fix the issue explain analyze with DML executors may respond to the client before the transaction commit has finished [#37373](https://github.com/pingcap/tidb/issues/37373) - Fix the issue that the region cache after merging many regions is not cleared properly [#37174](https://github.com/pingcap/tidb/issues/37174) @@ -99,10 +51,6 @@ TiDB version: 5.3.4 - (dup) Fix the issue that `GROUP CONCAT` with `ORDER BY` might fail when the `ORDER BY` clause contains a correlated subquery [#18216](https://github.com/pingcap/tidb/issues/18216) - Fix the issue that wrong length and width are set for Decimal and Real when using plan-cache [#29565](https://github.com/pingcap/tidb/issues/29565) -+ TiKV - - - + PD @@ -120,31 +68,17 @@ TiDB version: 5.3.4 - Fix the issue that TiFlash crash due to using `0.0` as the integer's default value. E.g. `i` int(11) NOT NULL DEFAULT '0.0' [#3157](https://github.com/pingcap/tiflash/issues/3157) -+ Tools - - + Backup & Restore (BR) - ++ Tools + Dumpling - - Fix the issue that dumpling can't dump with `--compress` option and s3 output directory [#30534](https://github.com/pingcap/tidb/issues/30534) + - Fix the issue that dumpling can't dump with `--compress` option and s3 output directory [#30534](https://github.com/pingcap/tidb/issues/30534) + + TiCDC - - Fix a issue that causes MySQL related error not reported to owner in time [#6698](https://github.com/pingcap/tiflow/issues/6698) - - + TiDB Binlog - - - - + TiDB Lightning - - - - + TiDB Data Migration (DM) - - + - Fix a issue that causes MySQL related error not reported to owner in time [#6698](https://github.com/pingcap/tiflow/issues/6698) From 351238ed601d3c5874255fcff766e032d7adec79 Mon Sep 17 00:00:00 2001 From: shichun-0415 Date: Mon, 21 Nov 2022 19:30:01 +0800 Subject: [PATCH 06/13] add dup for a txn note --- releases/release-5.3.4.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index 381df2cfdf7ab..e4af30920cdd6 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -35,14 +35,14 @@ TiDB version: 5.3.4 - (dup) Fix wrong results of `GREATEST` and `LEAST` when passing in unsigned `BIGINT` arguments [#30101](https://github.com/pingcap/tidb/issues/30101) - (dup) Fix the issue that the result of `concat(ifnull(time(3))` in TiDB is different from that in MySQL [#29498](https://github.com/pingcap/tidb/issues/29498) - - Fix the issue that avg() returns error `ERROR 1105 (HY000): other error for mpp stream: Could not convert to the target type - -value is out of range.` when quering from TiFlash [#29952](https://github.com/pingcap/tidb/issues/29952) + - Fix the issue that avg() returns error `ERROR 1105 (HY000): other error for mpp stream: Could not convert to the target type - -value is out of range.` when querying from TiFlash [#29952](https://github.com/pingcap/tidb/issues/29952) - Fix the issue that sql returns `ERROR 1105 (HY000): close of nil channel` when using HashJoinExec [#30289](https://github.com/pingcap/tidb/issues/30289) - Fix the different return type of date_add and date_sub between TiDB and MySQL. Change date_add and date_sub string_(int/string/real/decimal) function return type to string [#27573](https://github.com/pingcap/tidb/issues/27573) - Fix the problem that tikv and tiflash return different results when query logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) - - Fix the issue explain analyze with DML executors may respond to the client before the transaction commit has finished [#37373](https://github.com/pingcap/tidb/issues/37373) + - (dup) Fix the issue explain analyze with DML executors may respond to the client before the transaction commit has finished [#37373](https://github.com/pingcap/tidb/issues/37373) - Fix the issue that the region cache after merging many regions is not cleared properly [#37174](https://github.com/pingcap/tidb/issues/37174) From bea73a8c3c2ac41b4c95a37c4375e9ed07b45b79 Mon Sep 17 00:00:00 2001 From: shichun-0415 Date: Mon, 21 Nov 2022 19:33:32 +0800 Subject: [PATCH 07/13] Update release-5.3.4.md --- releases/release-5.3.4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index e4af30920cdd6..cd72eb2f852ea 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -42,7 +42,7 @@ TiDB version: 5.3.4 - - (dup) Fix the issue explain analyze with DML executors may respond to the client before the transaction commit has finished [#37373](https://github.com/pingcap/tidb/issues/37373) + - (dup) Fix the issue that the `EXPLAIN ANALYZE` statement with DML executors might return result before the transaction commit finishes [#37373](https://github.com/pingcap/tidb/issues/37373) - Fix the issue that the region cache after merging many regions is not cleared properly [#37174](https://github.com/pingcap/tidb/issues/37174) From 3e21af5d0e954640930aa68504050a69208047a7 Mon Sep 17 00:00:00 2001 From: shichun-0415 <89768198+shichun-0415@users.noreply.github.com> Date: Tue, 22 Nov 2022 19:26:14 +0800 Subject: [PATCH 08/13] Apply suggestions from code review Co-authored-by: Ran --- releases/release-5.3.4.md | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index cd72eb2f852ea..303726f718352 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -27,29 +27,28 @@ TiDB version: 5.3.4 - (dup) Fix the issue that database-level privileges are incorrectly cleaned up [#38363](https://github.com/pingcap/tidb/issues/38363) - (dup) Fix the issue that the `grantor` field is missing in the `mysql.tables_priv` table [#38293](https://github.com/pingcap/tidb/issues/38293) - (dup) Fix the issue that `KILL TIDB` cannot take effect immediately on idle connections [#24031](https://github.com/pingcap/tidb/issues/24031) - - Fix return type to string for `adddate` and `subdate` functions [#36394](https://github.com/pingcap/tidb/issues/36394) - - Fix restore table option `INSERT_METHOD` incompatible with MySQL [#38368](https://github.com/pingcap/tidb/issues/38368) - - Fix authentication with MySQL 5.1 and older clients [#29725](https://github.com/pingcap/tidb/issues/29725) + - Fix the issue that the return type of `date_add` and `date_sub` is different between TiDB and MySQL [#36394], [#27573](https://github.com/pingcap/tidb/issues/27573)(https://github.com/pingcap/tidb/issues/36394) + - Fix incorrect `INSERT_METHOD` in Parser's restore table options [#38368](https://github.com/pingcap/tidb/issues/38368) + - Fix the issue that authentication fails when a MySQL client of v5.1 or earlier connects with the TiDB server [#29725](https://github.com/pingcap/tidb/issues/29725) - (dup) Fix wrong results of `GREATEST` and `LEAST` when passing in unsigned `BIGINT` arguments [#30101](https://github.com/pingcap/tidb/issues/30101) - (dup) Fix the issue that the result of `concat(ifnull(time(3))` in TiDB is different from that in MySQL [#29498](https://github.com/pingcap/tidb/issues/29498) - - Fix the issue that avg() returns error `ERROR 1105 (HY000): other error for mpp stream: Could not convert to the target type - -value is out of range.` when querying from TiFlash [#29952](https://github.com/pingcap/tidb/issues/29952) - - Fix the issue that sql returns `ERROR 1105 (HY000): close of nil channel` when using HashJoinExec [#30289](https://github.com/pingcap/tidb/issues/30289) - - Fix the different return type of date_add and date_sub between TiDB and MySQL. Change date_add and date_sub string_(int/string/real/decimal) function return type to string [#27573](https://github.com/pingcap/tidb/issues/27573) - - Fix the problem that tikv and tiflash return different results when query logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) + - Fix the issue that the `avg()` function returns `ERROR 1105 (HY000): other error for mpp stream: Could not convert to the target type - -value is out of range.` when queried from TiFlash [#29952](https://github.com/pingcap/tidb/issues/29952) + - Fix the issue that `ERROR 1105 (HY000): close of nil channel` is returned when using `HashJoinExec` [#30289](https://github.com/pingcap/tidb/issues/30289) + - Fix the issue that TiKV and TiFlash return different results when query logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) - (dup) Fix the issue that the `EXPLAIN ANALYZE` statement with DML executors might return result before the transaction commit finishes [#37373](https://github.com/pingcap/tidb/issues/37373) - - Fix the issue that the region cache after merging many regions is not cleared properly [#37174](https://github.com/pingcap/tidb/issues/37174) + - Fix the issue that Region cache is not cleared properly after merging many Regions [#37174](https://github.com/pingcap/tidb/issues/37174) - (dup) Fix the issue that the EXECUTE might throw an unexpected error in specific scenarios [#37187](https://github.com/pingcap/tidb/issues/37187) - (dup) Fix the issue that `GROUP CONCAT` with `ORDER BY` might fail when the `ORDER BY` clause contains a correlated subquery [#18216](https://github.com/pingcap/tidb/issues/18216) - - Fix the issue that wrong length and width are set for Decimal and Real when using plan-cache [#29565](https://github.com/pingcap/tidb/issues/29565) + - Fix the issue of wrong results that occur because wrong length and width values are set for Decimal and Real when using plan cache [#29565](https://github.com/pingcap/tidb/issues/29565) + PD @@ -67,7 +66,7 @@ TiDB version: 5.3.4 - - Fix the issue that TiFlash crash due to using `0.0` as the integer's default value. E.g. `i` int(11) NOT NULL DEFAULT '0.0' [#3157](https://github.com/pingcap/tiflash/issues/3157) + - Fix the issue that TiFlash bootstrap fails caused by using `0.0` as the default value for integers. For example,`` `i` int(11) NOT NULL DEFAULT '0.0'`` [#3157](https://github.com/pingcap/tiflash/issues/3157) + Tools @@ -75,10 +74,10 @@ TiDB version: 5.3.4 - - Fix the issue that dumpling can't dump with `--compress` option and s3 output directory [#30534](https://github.com/pingcap/tidb/issues/30534) + - Fix the issue that Dumpling cannot dump when the `--compress` option and the S3 output directory are set simultaneously [#30534](https://github.com/pingcap/tidb/issues/30534) + TiCDC - - Fix a issue that causes MySQL related error not reported to owner in time [#6698](https://github.com/pingcap/tiflow/issues/6698) + - Fix the issue that changefeed state is incorrect because a MySQL-related error is not reported to the owner in time [#6698](https://github.com/pingcap/tiflow/issues/6698) From 4f8f282123050a4d17b29f69df05092479521cc7 Mon Sep 17 00:00:00 2001 From: Ran Date: Wed, 23 Nov 2022 14:14:58 +0800 Subject: [PATCH 09/13] Apply suggestions from code review Co-authored-by: shichun-0415 <89768198+shichun-0415@users.noreply.github.com> --- releases/release-5.3.4.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index 303726f718352..7744f520167d0 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -48,7 +48,7 @@ TiDB version: 5.3.4 - (dup) Fix the issue that the EXECUTE might throw an unexpected error in specific scenarios [#37187](https://github.com/pingcap/tidb/issues/37187) - (dup) Fix the issue that `GROUP CONCAT` with `ORDER BY` might fail when the `ORDER BY` clause contains a correlated subquery [#18216](https://github.com/pingcap/tidb/issues/18216) - - Fix the issue of wrong results that occur because wrong length and width values are set for Decimal and Real when using plan cache [#29565](https://github.com/pingcap/tidb/issues/29565) + - Fix wrong results returned when length and width are incorrectly set for Decimal and Real when using plan cache [#29565](https://github.com/pingcap/tidb/issues/29565) + PD @@ -62,11 +62,11 @@ TiDB version: 5.3.4 - - Fix the issue that logical operators return wrong results when the argument type is UInt8 [#6127](https://github.com/pingcap/tiflash/issues/6127) + - Fix the issue that logical operators return wrong results when the argument type is UInt8 [#6127](https://github.com/pingcap/tiflash/issues/6127) - - Fix the issue that TiFlash bootstrap fails caused by using `0.0` as the default value for integers. For example,`` `i` int(11) NOT NULL DEFAULT '0.0'`` [#3157](https://github.com/pingcap/tiflash/issues/3157) + - Fix the issue that TiFlash bootstrap fails when `0.0` is used as the default value for integers, for example, `` `i` int(11) NOT NULL DEFAULT '0.0'`` [#3157](https://github.com/pingcap/tiflash/issues/3157) + Tools @@ -74,7 +74,7 @@ TiDB version: 5.3.4 - - Fix the issue that Dumpling cannot dump when the `--compress` option and the S3 output directory are set simultaneously [#30534](https://github.com/pingcap/tidb/issues/30534) + - Fix the issue that Dumpling cannot dump data when the `--compress` option and the S3 output directory are set simultaneously [#30534](https://github.com/pingcap/tidb/issues/30534) + TiCDC From 498ee1340d3f022e014549d0a54fce20f8f5665a Mon Sep 17 00:00:00 2001 From: shichun-0415 <89768198+shichun-0415@users.noreply.github.com> Date: Wed, 23 Nov 2022 14:38:32 +0800 Subject: [PATCH 10/13] Apply suggestions from code review Co-authored-by: Ran --- releases/release-5.3.4.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index 7744f520167d0..d2fd5d2a73f58 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -27,9 +27,9 @@ TiDB version: 5.3.4 - (dup) Fix the issue that database-level privileges are incorrectly cleaned up [#38363](https://github.com/pingcap/tidb/issues/38363) - (dup) Fix the issue that the `grantor` field is missing in the `mysql.tables_priv` table [#38293](https://github.com/pingcap/tidb/issues/38293) - (dup) Fix the issue that `KILL TIDB` cannot take effect immediately on idle connections [#24031](https://github.com/pingcap/tidb/issues/24031) - - Fix the issue that the return type of `date_add` and `date_sub` is different between TiDB and MySQL [#36394], [#27573](https://github.com/pingcap/tidb/issues/27573)(https://github.com/pingcap/tidb/issues/36394) + - Fix the issue that the return type of `date_add` and `date_sub` is different between TiDB and MySQL [#36394](https://github.com/pingcap/tidb/issues/36394), [#27573](https://github.com/pingcap/tidb/issues/27573) - Fix incorrect `INSERT_METHOD` in Parser's restore table options [#38368](https://github.com/pingcap/tidb/issues/38368) - - Fix the issue that authentication fails when a MySQL client of v5.1 or earlier connects with the TiDB server [#29725](https://github.com/pingcap/tidb/issues/29725) + - Fix the issue that authentication fails when a MySQL client of v5.1 or earlier connects to the TiDB server [#29725](https://github.com/pingcap/tidb/issues/29725) @@ -37,7 +37,7 @@ TiDB version: 5.3.4 - (dup) Fix the issue that the result of `concat(ifnull(time(3))` in TiDB is different from that in MySQL [#29498](https://github.com/pingcap/tidb/issues/29498) - Fix the issue that the `avg()` function returns `ERROR 1105 (HY000): other error for mpp stream: Could not convert to the target type - -value is out of range.` when queried from TiFlash [#29952](https://github.com/pingcap/tidb/issues/29952) - Fix the issue that `ERROR 1105 (HY000): close of nil channel` is returned when using `HashJoinExec` [#30289](https://github.com/pingcap/tidb/issues/30289) - - Fix the issue that TiKV and TiFlash return different results when query logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) + - Fix the issue that TiKV and TiFlash return different results when querying logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) From cb4960fee75e88f5466fc109a279aa07dc5e5c61 Mon Sep 17 00:00:00 2001 From: Hangjie Mo Date: Wed, 23 Nov 2022 14:42:22 +0800 Subject: [PATCH 11/13] Update releases/release-5.3.4.md Co-authored-by: Ran --- releases/release-5.3.4.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index d2fd5d2a73f58..f74dff58a8708 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -28,7 +28,7 @@ TiDB version: 5.3.4 - (dup) Fix the issue that the `grantor` field is missing in the `mysql.tables_priv` table [#38293](https://github.com/pingcap/tidb/issues/38293) - (dup) Fix the issue that `KILL TIDB` cannot take effect immediately on idle connections [#24031](https://github.com/pingcap/tidb/issues/24031) - Fix the issue that the return type of `date_add` and `date_sub` is different between TiDB and MySQL [#36394](https://github.com/pingcap/tidb/issues/36394), [#27573](https://github.com/pingcap/tidb/issues/27573) - - Fix incorrect `INSERT_METHOD` in Parser's restore table options [#38368](https://github.com/pingcap/tidb/issues/38368) + - Fix the incorrect `INSERT_METHOD` value when Parser restores table options [#38368](https://github.com/pingcap/tidb/issues/38368) - Fix the issue that authentication fails when a MySQL client of v5.1 or earlier connects to the TiDB server [#29725](https://github.com/pingcap/tidb/issues/29725) From c5a6a5ab060e5d04db76734fc6fe0d78c770854d Mon Sep 17 00:00:00 2001 From: shichun-0415 Date: Wed, 23 Nov 2022 15:31:24 +0800 Subject: [PATCH 12/13] remove dup, owner, and add release date --- releases/release-5.3.4.md | 54 ++++++++++-------------------------- releases/release-notes.md | 2 +- releases/release-timeline.md | 2 +- 3 files changed, 17 insertions(+), 41 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index f74dff58a8708..b79269bc71f33 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -4,7 +4,7 @@ title: TiDB 5.3.4 Release Note # TiDB 5.3.4 Release Note -Release date: xx, xx, 2022 +Release date: November 24, 2022 TiDB version: 5.3.4 @@ -12,72 +12,48 @@ TiDB version: 5.3.4 + TiKV - - - - (dup) Reload TLS certificate automatically for each update to improve availability [#12546](https://github.com/tikv/tikv/issues/12546) + - Reload TLS certificate automatically for each update to improve availability [#12546](https://github.com/tikv/tikv/issues/12546) ## Bug fixes + TiDB - - - - (dup) Fix the issue that the Region cache is not cleaned up in time when the Region is merged[#37141](https://github.com/pingcap/tidb/issues/37141) - - (dup) Fix the issue that TiDB writes wrong data due to the wrong encoding of the ENUM or SET column [#32302](https://github.com/pingcap/tidb/issues/32302) - - (dup) Fix the issue that database-level privileges are incorrectly cleaned up [#38363](https://github.com/pingcap/tidb/issues/38363) - - (dup) Fix the issue that the `grantor` field is missing in the `mysql.tables_priv` table [#38293](https://github.com/pingcap/tidb/issues/38293) - - (dup) Fix the issue that `KILL TIDB` cannot take effect immediately on idle connections [#24031](https://github.com/pingcap/tidb/issues/24031) + - Fix the issue that the Region cache is not cleaned up in time when the Region is merged [#37141](https://github.com/pingcap/tidb/issues/37141) + - Fix the issue that TiDB writes wrong data due to the wrong encoding of the `ENUM` or `SET` column [#32302](https://github.com/pingcap/tidb/issues/32302) + - Fix the issue that database-level privileges are incorrectly cleaned up [#38363](https://github.com/pingcap/tidb/issues/38363) + - Fix the issue that the `grantor` field is missing in the `mysql.tables_priv` table [#38293](https://github.com/pingcap/tidb/issues/38293) + - Fix the issue that `KILL TIDB` cannot take effect immediately on idle connections [#24031](https://github.com/pingcap/tidb/issues/24031) - Fix the issue that the return type of `date_add` and `date_sub` is different between TiDB and MySQL [#36394](https://github.com/pingcap/tidb/issues/36394), [#27573](https://github.com/pingcap/tidb/issues/27573) - Fix the incorrect `INSERT_METHOD` value when Parser restores table options [#38368](https://github.com/pingcap/tidb/issues/38368) - Fix the issue that authentication fails when a MySQL client of v5.1 or earlier connects to the TiDB server [#29725](https://github.com/pingcap/tidb/issues/29725) - - - - - (dup) Fix wrong results of `GREATEST` and `LEAST` when passing in unsigned `BIGINT` arguments [#30101](https://github.com/pingcap/tidb/issues/30101) - - (dup) Fix the issue that the result of `concat(ifnull(time(3))` in TiDB is different from that in MySQL [#29498](https://github.com/pingcap/tidb/issues/29498) + - Fix wrong results of `GREATEST` and `LEAST` when passing in unsigned `BIGINT` arguments [#30101](https://github.com/pingcap/tidb/issues/30101) + - Fix the issue that the result of `concat(ifnull(time(3))` in TiDB is different from that in MySQL [#29498](https://github.com/pingcap/tidb/issues/29498) - Fix the issue that the `avg()` function returns `ERROR 1105 (HY000): other error for mpp stream: Could not convert to the target type - -value is out of range.` when queried from TiFlash [#29952](https://github.com/pingcap/tidb/issues/29952) - Fix the issue that `ERROR 1105 (HY000): close of nil channel` is returned when using `HashJoinExec` [#30289](https://github.com/pingcap/tidb/issues/30289) - Fix the issue that TiKV and TiFlash return different results when querying logical operations [#37258](https://github.com/pingcap/tidb/issues/37258) - - - - - (dup) Fix the issue that the `EXPLAIN ANALYZE` statement with DML executors might return result before the transaction commit finishes [#37373](https://github.com/pingcap/tidb/issues/37373) + - Fix the issue that the `EXPLAIN ANALYZE` statement with DML executors might return result before the transaction commit finishes [#37373](https://github.com/pingcap/tidb/issues/37373) - Fix the issue that Region cache is not cleared properly after merging many Regions [#37174](https://github.com/pingcap/tidb/issues/37174) - - - - - (dup) Fix the issue that the EXECUTE might throw an unexpected error in specific scenarios [#37187](https://github.com/pingcap/tidb/issues/37187) - - (dup) Fix the issue that `GROUP CONCAT` with `ORDER BY` might fail when the `ORDER BY` clause contains a correlated subquery [#18216](https://github.com/pingcap/tidb/issues/18216) + - Fix the issue that the `EXECUTE` statement might throw an unexpected error in specific scenarios [#37187](https://github.com/pingcap/tidb/issues/37187) + - Fix the issue that `GROUP CONCAT` with `ORDER BY` might fail when the `ORDER BY` clause contains a correlated subquery [#18216](https://github.com/pingcap/tidb/issues/18216) - Fix wrong results returned when length and width are incorrectly set for Decimal and Real when using plan cache [#29565](https://github.com/pingcap/tidb/issues/29565) + PD - - - - (dup) Fix the issue that PD cannot correctly handle dashboard proxy requests [#5321](https://github.com/tikv/pd/issues/5321) - - (dup) Fix the issue that the TiFlash learner replica might not be created in specific scenarios [#5401](https://github.com/tikv/pd/issues/5401) - - (dup) Fix inaccurate Stream timeout and accelerate leader switchover [#5207](https://github.com/tikv/pd/issues/5207) + - Fix the issue that PD cannot correctly handle dashboard proxy requests [#5321](https://github.com/tikv/pd/issues/5321) + - Fix the issue that the TiFlash learner replica might not be created in specific scenarios [#5401](https://github.com/tikv/pd/issues/5401) + - Fix inaccurate Stream timeout and accelerate leader switchover [#5207](https://github.com/tikv/pd/issues/5207) + TiFlash - - - Fix the issue that logical operators return wrong results when the argument type is UInt8 [#6127](https://github.com/pingcap/tiflash/issues/6127) - - - - Fix the issue that TiFlash bootstrap fails when `0.0` is used as the default value for integers, for example, `` `i` int(11) NOT NULL DEFAULT '0.0'`` [#3157](https://github.com/pingcap/tiflash/issues/3157) + Tools + Dumpling - - - Fix the issue that Dumpling cannot dump data when the `--compress` option and the S3 output directory are set simultaneously [#30534](https://github.com/pingcap/tidb/issues/30534) + TiCDC - - - Fix the issue that changefeed state is incorrect because a MySQL-related error is not reported to the owner in time [#6698](https://github.com/pingcap/tiflow/issues/6698) diff --git a/releases/release-notes.md b/releases/release-notes.md index a3062b276fb26..fc7deca560919 100644 --- a/releases/release-notes.md +++ b/releases/release-notes.md @@ -36,7 +36,7 @@ aliases: ['/docs/dev/releases/release-notes/','/docs/dev/releases/rn/'] ## 5.3 -- [5.3.4](/releases/release-5.3.4.md): 2022-xx-xx +- [5.3.4](/releases/release-5.3.4.md): 2022-11-24 - [5.3.3](/releases/release-5.3.3.md): 2022-09-14 - [5.3.2](/releases/release-5.3.2.md): 2022-06-29 - [5.3.1](/releases/release-5.3.1.md): 2022-03-03 diff --git a/releases/release-timeline.md b/releases/release-timeline.md index 4c2eba0121009..19017ceaf9c00 100644 --- a/releases/release-timeline.md +++ b/releases/release-timeline.md @@ -9,7 +9,7 @@ This document shows all the released TiDB versions in reverse chronological orde | Version | Release Date | | :--- | :--- | -| [5.3.4](/releases/release-5.3.4.md) | 2022-xx-xx | +| [5.3.4](/releases/release-5.3.4.md) | 2022-11-24 | | [6.4.0-DMR](/releases/release-6.4.0.md) | 2022-11-17 | | [6.1.2](/releases/release-6.1.2.md) | 2022-10-24 | | [5.4.3](/releases/release-5.4.3.md) | 2022-10-13 | From b101e97cdc9dc4f038341d27cd4dfc75fdaac437 Mon Sep 17 00:00:00 2001 From: shichun-0415 Date: Thu, 24 Nov 2022 11:09:12 +0800 Subject: [PATCH 13/13] refine --- releases/release-5.3.4.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/releases/release-5.3.4.md b/releases/release-5.3.4.md index b79269bc71f33..ca20e7ca1c7d3 100644 --- a/releases/release-5.3.4.md +++ b/releases/release-5.3.4.md @@ -1,8 +1,8 @@ --- -title: TiDB 5.3.4 Release Note +title: TiDB 5.3.4 Release Notes --- -# TiDB 5.3.4 Release Note +# TiDB 5.3.4 Release Notes Release date: November 24, 2022