Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tikv configs: add 7 log-related configs #6996

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Aug 26, 2021

What is changed, added or deleted? (Required)

tikv configs: add 7 log-related configs

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 26, 2021
@TomShawn TomShawn requested a review from glkappe August 26, 2021 11:27
@TomShawn TomShawn added translation/doing This PR’s assignee is translating this PR. type/enhancement The issue or PR belongs to an enhancement. needs-cherry-pick-release-4.0 and removed missing-translation-status This PR does not have translation status info. labels Aug 26, 2021
@ti-chi-bot
Copy link
Member

@tabokie: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@glkappe
Copy link
Contributor

glkappe commented Aug 31, 2021

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 1, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Sep 1, 2021

need add 2 log-related configs,https://github.com/tikv/tikv/blob/b32ee4afcb2932b0b4bec6ebeef24bd0547dbf5a/etc/config-template.toml#L10

line 23 and 26

Done. PTAL

Copy link
Contributor

@glkappe glkappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

Copy link
Contributor

@glkappe glkappe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn changed the title tikv configs: add 5 log-related configs tikv configs: add 7 log-related configs Sep 1, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Sep 1, 2021

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 1, 2021
@TomShawn
Copy link
Contributor Author

TomShawn commented Sep 1, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 296e741

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 1, 2021
@ti-chi-bot ti-chi-bot merged commit e8debeb into pingcap:master Sep 1, 2021
@TomShawn TomShawn deleted the log-lebvel branch September 1, 2021 06:16
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Sep 1, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7059.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7060.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7061.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7062.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants