Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grafana-tidb-dashboard.md #5753

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Update grafana-tidb-dashboard.md #5753

merged 1 commit into from
Mar 17, 2021

Conversation

xyqcmss
Copy link

@xyqcmss xyqcmss commented Mar 17, 2021 •
edited
Loading

这一行在新的v5.0.0-rc的监控页面中没有，

  • Wait Duration 95：等待处理的 Batch 消息延迟

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@xyqcmss
Update grafana-tidb-dashboard.md
8311a89 
这一行在新的v5.0.0-rc的监控页面中没有，
- Wait Duration 95：等待处理的 Batch 消息延迟
@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Mar 17, 2021
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2021
@xyqcmss
Copy link
Author

xyqcmss commented Mar 17, 2021 •
edited
Loading

/cc @TomShawn
辛苦您，再看一下！谢谢

@ti-chi-bot ti-chi-bot requested a review from TomShawn March 17, 2021 04:28
@TomShawn
Copy link
Contributor

/cc jackysp
/size small
/translation welcome

@ti-chi-bot ti-chi-bot requested a review from jackysp March 17, 2021 06:07
@ti-chi-bot ti-chi-bot added size/small Changes of a small size. translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. and removed missing-translation-status This PR does not have translation status info. labels Mar 17, 2021
@TomShawn
Copy link
Contributor

/label needs-cherry-pick-master

@ti-chi-bot ti-chi-bot added the needs-cherry-pick-master Should cherry pick this PR to master branch. label Mar 17, 2021
@TomShawn TomShawn mentioned this pull request Mar 17, 2021
Closed
11 tasks
jackysp
jackysp reviewed Mar 17, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member

jackysp commented Mar 17, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • jackysp

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 17, 2021
TomShawn
TomShawn approved these changes Mar 17, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8311a89

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 17, 2021
@ti-chi-bot ti-chi-bot merged commit 1665acb into pingcap:release-5.0 Mar 17, 2021
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Mar 17, 2021
@xyqcmss @ti-srebot
cherry pick pingcap#5753 to master
0a4c2a5 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Mar 17, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to master in PR #5760

ti-chi-bot pushed a commit that referenced this pull request Mar 18, 2021
@ti-srebot
Update grafana-tidb-dashboard.md (#5753) (#5760)
c115dc7
@chunleiz
Copy link
Contributor

/assign

@chunleiz
Copy link
Contributor

/remove-translation welcome

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. and removed translation/welcome Waits for a contributor to translate this PR and create a PR to the pingcap/docs-cn repository. labels Jul 31, 2021
@chunleiz
Copy link
Contributor

/translation doing

@ti-chi-bot ti-chi-bot added translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 31, 2021
@chunleiz chunleiz mentioned this pull request Jul 31, 2021
Merged
8 tasks
@chunleiz
Copy link
Contributor

/translation from-docs-cn

@ti-chi-bot
Copy link
Member

@chunleiz: The label(s) translation/from-docs-cn cannot be applied, because the repository doesn't have them.

In response to this:

/translation from-docs-cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. translation/doing This PR’s assignee is translating this PR. and removed translation/doing This PR’s assignee is translating this PR. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Aug 2, 2021
@TomShawn TomShawn assigned en-jin19 and unassigned chunleiz Aug 2, 2021
@en-jin19 en-jin19 mentioned this pull request Aug 2, 2021
Merged
11 tasks
@en-jin19 en-jin19 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 2, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 2, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@TomShawn TomShawn TomShawn approved these changes

Assignees

@en-jin19 en-jin19

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-master Should cherry pick this PR to master branch. size/small Changes of a small size. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@xyqcmss @TomShawn @jackysp @ti-chi-bot @ti-srebot @chunleiz @en-jin19