Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reference: delete execution-plan-bind for v2.1 #2059

Merged
merged 2 commits into from
Nov 26, 2019
Merged

reference: delete execution-plan-bind for v2.1 #2059

merged 2 commits into from
Nov 26, 2019

Conversation

aytrack
Copy link
Contributor

@aytrack aytrack commented Nov 21, 2019

What is changed, added or deleted?

It seems that TiDB v2.1 does not support execution plan binding, so delete it from the doc.

What is the related PR or file link(s)?

Which version does your change affect?

TiDB v2.1

@lilin90 lilin90 added the translation/doing This PR’s assignee is translating this PR. label Nov 21, 2019
@lilin90 lilin90 requested a review from XuHuaiyu November 21, 2019 06:40
@XuHuaiyu
Copy link
Contributor

PTAL @lamxTyler

@XuHuaiyu XuHuaiyu removed their request for review November 26, 2019 09:02
@lilin90 lilin90 assigned yikeke and unassigned TomShawn Nov 26, 2019
@lilin90 lilin90 added the size/small Changes of a small size. label Nov 26, 2019
@yikeke yikeke requested a review from alivxxx November 26, 2019 09:39
alivxxx
alivxxx reviewed Nov 26, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yikeke
yikeke approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@yikeke yikeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yikeke yikeke merged commit 2e86203 into pingcap:master Nov 26, 2019
@yikeke yikeke added translation/no-need No need to translate this PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 26, 2019
@yikeke
Copy link
Contributor

yikeke commented Nov 26, 2019 •
edited
Loading

We haven't included the execution-plan-bind.md file in the English v2.1 folder. So no need to align this PR, FYI. @lilin90

@lilin90
Copy link
Member

lilin90 commented Nov 26, 2019

@yikeke That's good. Related PR: pingcap/docs#1249

@yikeke yikeke removed the size/small Changes of a small size. label Nov 26, 2019
@yikeke yikeke removed their assignment Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@yikeke yikeke yikeke approved these changes

Assignees
No one assigned
Labels
translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aytrack @XuHuaiyu @yikeke @lilin90 @alivxxx @TomShawn