Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dm-ctl/: add --more index for query-status command to get full task information(#523) #533

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

WangXiangUSTC
Copy link
Contributor

cherry-pick #523

What problem does this PR solve?

Add --more index for query-status command to get full task information.

What is changed and how it works?

It will check --more index for query-status command. If this index exist, it will print full tasks information.

Check List

Tests

  • No code

@WangXiangUSTC WangXiangUSTC added status/PTAL This PR is ready for review. Add this label back after committing new changes type/cherry-pick This PR is just a cherry-pick (backport) labels Mar 12, 2020
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

@WangXiangUSTC
Copy link
Contributor Author

@lichunzhu @csuzhangxc PTAL

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

1 similar comment
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #533 into release-1.0 will increase coverage by 0.0188%.
The diff coverage is 29.7297%.

@@                 Coverage Diff                 @@
##           release-1.0       #533        +/-   ##
===================================================
+ Coverage      57.3006%   57.3194%   +0.0188%     
===================================================
  Files              161        161                
  Lines            16656      16661         +5     
===================================================
+ Hits              9544       9550         +6     
- Misses            6166       6167         +1     
+ Partials           946        944         -2     

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests tidb=release-3.0

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Mar 12, 2020
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Mar 12, 2020
@csuzhangxc csuzhangxc merged commit 392f9ff into release-1.0 Mar 12, 2020
@csuzhangxc csuzhangxc deleted the xiang/pick_dmctl branch March 12, 2020 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants