Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

br can not backup and resotore tidb system databases like mysql.user #872

Closed
wangbincmsss opened this issue Mar 15, 2021 · 5 comments
Closed
Labels
question Further information is requested

Comments

@wangbincmsss
Copy link

wangbincmsss commented Mar 15, 2021

Question

i want to backup and restore all tidb data , but br can not backup and resotore tidb system databases
and i see this in code
image
br can not backup and restore tidb system databases like mysql.user
i want to know the reason ?

@wangbincmsss
Copy link
Author

\cc @kennytm

@kennytm
Copy link
Collaborator

kennytm commented Mar 15, 2021

@wangbinhe3db we explicitly opt out of system tables. Because if the user wrongly restore on a cluster with different schema version, BR can easily brick the entire cluster. See #679 for the intended direction how we'd like to handle system tables.

@kennytm kennytm added the question Further information is requested label Mar 15, 2021
@SunRunAway
Copy link
Contributor

  1. mysql.user may have the account information which customer may forget in their brain.
  2. TiDB allow a customer to create a table in the mysql schema.

I suggest we should backup the system tables, and can opt out when restoring.

@kennytm @IANTHEREAL

@SunRunAway
Copy link
Contributor

The second reason is very important and critical.

As a matter of principle, we should also back up everything and restore selectively, instead of backuping selectively.

@kennytm
Copy link
Collaborator

kennytm commented Apr 20, 2021

@SunRunAway please discuss the plan about system tables in #679. i'm closing this issue as duplicate.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants