-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded to Angular 1.3.1, Foundation 5.4.7 and Font Awesome 4.2 #144
Conversation
Thanks @circlingthesun! Based on your latest commit, does this include the |
Yeah, the unit tests don't pass without the fix. I was considering making the tests run for both Angular 1.2 and 1.3 as many people are probably still migrating and some new fixes might break backwards compatibility. I had some trouble finding a sensible way to configure grunt-karma-runner to use different library versions though. |
That's funny because running tests on current and Angular 1.2 is exactly what I've been working on since my last comment 😉. I just upgraded to the latest Karma version to prepare and will handle that after this is merged. Sorry, still unsure: do I need to merge both this and #143 to fix the |
Awesome :) Only this one is necessary. I sensed a reluctance to upgrade to 1.3 so I submitted two PR's. |
👍 Thanks again @circlingthesun. |
Upgraded to Angular 1.3.1, Foundation 5.4.7 and Font Awesome 4.2
:) |
I'm using the latest mm-foundation-tpls-0.5.0.min.js and Angular 1.3.1, but tooltips still do not get the "fade in" classes set to the element. They do show, just immediately without transition due to missing those classes. Am I missing something, should this be fixed with this update? Originally reported in #135 |
This PR upgrades Angular Foundation to the latest versions of Angular, Foundation and Font Awesome. It also fixes related unit test and demo page breakages.