Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded to Angular 1.3.1, Foundation 5.4.7 and Font Awesome 4.2 #144

Merged
merged 3 commits into from
Nov 7, 2014
Merged

Upgraded to Angular 1.3.1, Foundation 5.4.7 and Font Awesome 4.2 #144

merged 3 commits into from
Nov 7, 2014

Conversation

circlingthesun
Copy link
Contributor

This PR upgrades Angular Foundation to the latest versions of Angular, Foundation and Font Awesome. It also fixes related unit test and demo page breakages.

@jbrowning
Copy link
Member

Thanks @circlingthesun! Based on your latest commit, does this include the $observe fix or is #143 required as well?

@circlingthesun
Copy link
Contributor Author

Yeah, the unit tests don't pass without the fix. I was considering making the tests run for both Angular 1.2 and 1.3 as many people are probably still migrating and some new fixes might break backwards compatibility. I had some trouble finding a sensible way to configure grunt-karma-runner to use different library versions though.

@jbrowning
Copy link
Member

That's funny because running tests on current and Angular 1.2 is exactly what I've been working on since my last comment 😉. I just upgraded to the latest Karma version to prepare and will handle that after this is merged.

Sorry, still unsure: do I need to merge both this and #143 to fix the $observe bug or only this PR?

@circlingthesun
Copy link
Contributor Author

Awesome :) Only this one is necessary. I sensed a reluctance to upgrade to 1.3 so I submitted two PR's.

@jbrowning
Copy link
Member

👍 Thanks again @circlingthesun.

jbrowning added a commit that referenced this pull request Nov 7, 2014
Upgraded to Angular 1.3.1, Foundation 5.4.7 and Font Awesome 4.2
@jbrowning jbrowning merged commit 8bd6e50 into yalabot:master Nov 7, 2014
@circlingthesun
Copy link
Contributor Author

:)

@okcompewter
Copy link

I'm using the latest mm-foundation-tpls-0.5.0.min.js and Angular 1.3.1, but tooltips still do not get the "fade in" classes set to the element. They do show, just immediately without transition due to missing those classes. Am I missing something, should this be fixed with this update?

Originally reported in #135

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants