Bugfix: in subscriptions.create, trial_days using timezone naive utcnow() and add test #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #576 +/- ##
=======================================
Coverage 99.21% 99.21%
=======================================
Files 33 33
Lines 1917 1917
Branches 175 175
=======================================
Hits 1902 1902
Misses 7 7
Partials 8 8
Continue to review full report at Codecov.
|
blueyed
reviewed
Jul 13, 2018
| @@ -48,7 +48,7 @@ def create(customer, plan, quantity=None, trial_days=None, token=None, coupon=No | |||
|
|
|||
| subscription_params = {} | |||
| if trial_days: | |||
| subscription_params["trial_end"] = datetime.datetime.utcnow() + datetime.timedelta(days=trial_days) | |||
| subscription_params["trial_end"] = datetime.datetime.now(tz=timezone.utc) + datetime.timedelta(days=trial_days) | |||
There was a problem hiding this comment.
What about using django.utils.timezone.now()?
It seems to be used in other places.
There was a problem hiding this comment.
Changed another occurrence in #577 for consistency.
blueyed
added a commit
to blueyed/pinax-stripe
that referenced
this pull request
Jul 13, 2018
…ow() - Changed to timezone.now() - Add test Fixed pinax#573
miaoz2001
force-pushed
the
573-zhuangmiao-trial_end-days
branch
from
de9dcfb to
c987308
Compare
|
@blueyed yeah, i agree it's better and I have changed the code accordingly. |
blueyed
approved these changes
Jul 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: in subscriptions.create, trial_days using timezone naive utcnow() and add test
Fixes #573
What's this PR do?
Bugfix: in subscriptions.create, trial_days using timezone naive utcnow() and add test
Any background context you want to provide?
Issue #573
What ticket or issue # does this fix?
Issue #573
Closes #573
Definition of Done (check if considered and/or addressed):