Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription Not Canceled on Failed Charge #339

Open
tbell511 opened this issue Jun 9, 2017 · 4 comments
Open

Subscription Not Canceled on Failed Charge #339

tbell511 opened this issue Jun 9, 2017 · 4 comments
Assignees
Labels

Comments

@tbell511
Copy link

tbell511 commented Jun 9, 2017

I have a problem with customer subscriptions not cancelling when there is a failed charge on a recurring payment.

I created a plan with a 1day free trial, and used Striped test card that will fail.
For 1 day, the customers subscription said "trialling". Okay perfect.
When the charge failed, stripe immediately cancelled the subscription and sent all the necessary web hooks that were received and processed. Yet that particular subscription now says "active". The "delinquent" option on that account was set to true though.

What could be causing this? I am confused because the admin is telling me the webhooks were "successfully" processed.

Thanks!

@paltman paltman added the bug label Aug 25, 2017
@paltman paltman added this to the Samwise milestone Aug 25, 2017
@paltman
Copy link
Contributor

paltman commented Aug 25, 2017

We should probably write a test of some sort to simulate/reproduce this so we can fix. I suspect that while all webhooks say "processed" some are just defaulting and not calling the appropriate action to sync or the attributes expected have changed.

@gregnewman gregnewman self-assigned this Aug 25, 2017
@gregnewman
Copy link
Contributor

@formatically can you give me some more information? What does updated, canceled_at and cancel_at_period_end have for values? Also, what is your stripe settings for retries and what is the count on that? I realize this ticket is dated but maybe you still have some insight into those?

I have written tests for the sync method and it's updating properly. However, I'm curious what those values are above.

@tbell511
Copy link
Author

@gregnewman For a test, I just subscribed to another subscription that will fail in 1 day. I can get that information to you as soon as it fails. That being said, I am pretty sure I fixed the issue by creating a receiver that listened for a particular webhook. I'll get all that information to you as well.

Just wondering, do you know of a better way to test failed charges? It's annoying having to wait an entire day to see if code works!

@gregnewman
Copy link
Contributor

Thanks @formatically. Unfortunately I don't aside from writing a test. But the data that is sent via the webhooks might not be identical to what I'm using in my tests.

@paltman paltman modified the milestones: Samwise, Rosie Oct 30, 2017
@paltman paltman modified the milestones: Rosie, December 2017 Sprint Dec 1, 2017
@paltman paltman removed this from the December 2017 Sprint milestone Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants