Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track artist is not displayed in browse results #99

Closed
kingosticks opened this issue Apr 24, 2015 · 3 comments · Fixed by #182
Closed

Track artist is not displayed in browse results #99

kingosticks opened this issue Apr 24, 2015 · 3 comments · Fixed by #182
Assignees

Comments

@kingosticks
Copy link
Member

Originally posted at https://discuss.mopidy.com/t/artist-name-not-displayed-in-several-screens/682

I'm just in the process of upgrading from musicbox 0.53 to 0.6 and noticed that the artist name is no longer displayed in the "Queue" screen.
While I quite like the additional line showing the album name and album artist, the individual artists of the tracks are missing. This makes identifying the songs rather difficult.

@kingosticks
Copy link
Member Author

On further inspection, it seems that in the playlist and search pages, if there is just a single track from an album (and therefore no grey album row) you are shown the artist name alongside the track name. If you play from these pages then this is displayed the same way in the queue. So this is intentional behaviour.

Browse works somewhat differently. Here we are returned lightweight Ref objects which don't contain the artist/album metadata. So you only get the track name. But since Mopidy v1.0+ is moving towards using Refs everywhere we'll need to handle this anyway. I guess we need to do lookups on all the returned results...

@kingosticks kingosticks changed the title Track artist is not displayed in browse/playlist/queue screens Track artist is not displayed in browse results Apr 25, 2015
@jcass77 jcass77 self-assigned this Mar 6, 2016
@jcass77
Copy link
Member

jcass77 commented Mar 7, 2016

I have a question on this, having recently worked on refactoring the code responsible for displaying list of tracks as part of the search results and the 'now playing' queue.

Although I appreciate that it would be nice to have all of the various lists look and behave in an identical way, is the intention of using Refs not specifically to improve performance? I did a quick test and doing lookups on large numbers of track Refs does cause a noticeable delay during which the browser becomes unresponsive, even when using promises.

Is an effective implementation of this not blocked by the ability to paginate results as described in mopidy/mopidy#1392 and mopidy/mopidy#733?

In the interim, using something like mopidy-local-sqlite might be a more effective means of browsing large collections of albums and artists.

@kingosticks
Copy link
Member Author

Yes, Refs are a big improvement when you can save transferring lots of metadata around that you don't care about. I think the idea here was saying that maybe we do care about this rich metadata when browsing. You could argue that for the local backend, we do/should care but for the file backend we don't.

I'm not sure I understand how the user's particular local backend affects us.

jcass77 added a commit to jcass77/Mopidy-MusicBox-Webclient that referenced this issue Mar 10, 2016
jcass77 added a commit to jcass77/Mopidy-MusicBox-Webclient that referenced this issue Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants