Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use explicit Mopidy.js calling convention #79

Closed
jodal opened this issue Mar 5, 2015 · 1 comment
Closed

Use explicit Mopidy.js calling convention #79

jodal opened this issue Mar 5, 2015 · 1 comment
Assignees

Comments

@jodal
Copy link
Member

jodal commented Mar 5, 2015

In Mopidy.js 0.4 / Mopidy 0.19 a new "calling convention" setting was added to Mopidy.js. See https://docs.mopidy.com/en/latest/api/js/#creating-an-instance for details.

It seems MusicBox-Webclient still doesn't explicitly set the calling convention of Mopidy.js, so it defaults to "by-position-only". This default will change in the future, and when that happens, MusicBox-Webclient will break as is.

In the Mopidy.js docs, there's some motivation for changing to the new alternative calling convention, "by-position-or-by-name". The migration to it can be as simple as adding [] brackets around all existing Mopidy.js calls.

@kingosticks
Copy link
Member

Great, nice work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants